[PATCH BlueZ v1] client: Fix gatt.{read, write} not working on scripts

[PATCH BlueZ v1] client: Fix gatt.{read, write} not working on scripts

[Luiz Augusto von Dentz]

From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

If gatt.{read, write} are called within a script they don't indicate
completion so they block commands to be run after them.
---
 client/gatt.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/client/gatt.c b/client/gatt.c
index b18186518953..6dc80e2a31cd 100644
--- a/client/gatt.c
+++ b/client/gatt.c
@@ -696,6 +696,8 @@ void gatt_read_local_attribute(char *data, int argc, char *argv[])
 		bt_shell_hexdump(&d->value[offset], d->value_len - offset);
 		return bt_shell_noninteractive_quit(EXIT_SUCCESS);
 	}
+
+	return bt_shell_noninteractive_quit(EXIT_FAILURE);
 }
 
 static uint8_t *str2bytearray(char *arg, size_t *val_len)
@@ -809,6 +811,8 @@ void gatt_write_local_attribute(char *data, int argc, char *argv[])
 	}
 
 	free(value);
+
+	return bt_shell_noninteractive_quit(EXIT_SUCCESS);
 }
 
 static char *attribute_generator(const char *text, int state, GList *source)
-- 
2.50.1

RE: [BlueZ,v1] client: Fix gatt.{read, write} not working on scripts

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 1261 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=984445

---Test result---

Test Summary:
CheckPatch                    PENDING   0.29 seconds
GitLint                       PENDING   0.27 seconds
BuildEll                      PASS      20.49 seconds
BluezMake                     PASS      2636.17 seconds
MakeCheck                     PASS      20.59 seconds
MakeDistcheck                 PASS      189.93 seconds
CheckValgrind                 PASS      242.87 seconds
CheckSmatch                   PASS      315.63 seconds
bluezmakeextell               PASS      131.75 seconds
IncrementalBuild              PENDING   0.27 seconds
ScanBuild                     PASS      926.47 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:



---
Regards,
Linux Bluetooth

Re: [PATCH BlueZ v1] client: Fix gatt.{read, write} not working on scripts

[patchwork-bot+bluetooth]

Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Mon, 21 Jul 2025 16:09:33 -0400 you wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> 
> If gatt.{read, write} are called within a script they don't indicate
> completion so they block commands to be run after them.
> ---
>  client/gatt.c | 4 ++++
>  1 file changed, 4 insertions(+)

Here is the summary with links:
  - [BlueZ,v1] client: Fix gatt.{read, write} not working on scripts
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=06d73a43a854

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html