linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH BlueZ] device: fix auto connect with private addresses
@ 2025-08-26 11:43 Andreas Kemnade
  2025-08-26 13:05 ` [BlueZ] " bluez.test.bot
  2025-08-26 13:40 ` [PATCH BlueZ] " patchwork-bot+bluetooth
  0 siblings, 2 replies; 3+ messages in thread
From: Andreas Kemnade @ 2025-08-26 11:43 UTC (permalink / raw)
  To: linux-bluetooth; +Cc: Andreas Kemnade

When an app is registered and a device gets paired,
device_set_auto_connect() can be called before the address is resolved.
Do not ignore the request but rather record the auto connect request so
that it can be enabled in device_update_addr.
---
 src/device.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/device.c b/src/device.c
index 0179c3dab..8b3e78995 100644
--- a/src/device.c
+++ b/src/device.c
@@ -2205,7 +2205,7 @@ static void device_set_auto_connect(struct btd_device *device, gboolean enable)
 	char addr[18];
 	const char *bearer;
 
-	if (!device || !device->le || device_address_is_private(device))
+	if (!device || !device->le)
 		return;
 
 	ba2str(&device->bdaddr, addr);
@@ -2224,6 +2224,9 @@ static void device_set_auto_connect(struct btd_device *device, gboolean enable)
 		return;
 	}
 
+	if (device_address_is_private(device))
+		return;
+
 	/* Inhibit auto connect if BR/EDR bearer is preferred */
 	bearer = device_prefer_bearer_str(device);
 	if (bearer && !strcasecmp(bearer, "bredr"))
-- 
2.47.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* RE: [BlueZ] device: fix auto connect with private addresses
  2025-08-26 11:43 [PATCH BlueZ] device: fix auto connect with private addresses Andreas Kemnade
@ 2025-08-26 13:05 ` bluez.test.bot
  2025-08-26 13:40 ` [PATCH BlueZ] " patchwork-bot+bluetooth
  1 sibling, 0 replies; 3+ messages in thread
From: bluez.test.bot @ 2025-08-26 13:05 UTC (permalink / raw)
  To: linux-bluetooth, andreas

[-- Attachment #1: Type: text/plain, Size: 1261 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=995640

---Test result---

Test Summary:
CheckPatch                    PENDING   0.43 seconds
GitLint                       PENDING   0.50 seconds
BuildEll                      PASS      20.10 seconds
BluezMake                     PASS      2664.11 seconds
MakeCheck                     PASS      19.97 seconds
MakeDistcheck                 PASS      185.78 seconds
CheckValgrind                 PASS      239.23 seconds
CheckSmatch                   PASS      308.28 seconds
bluezmakeextell               PASS      131.07 seconds
IncrementalBuild              PENDING   0.50 seconds
ScanBuild                     PASS      926.77 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:



---
Regards,
Linux Bluetooth


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH BlueZ] device: fix auto connect with private addresses
  2025-08-26 11:43 [PATCH BlueZ] device: fix auto connect with private addresses Andreas Kemnade
  2025-08-26 13:05 ` [BlueZ] " bluez.test.bot
@ 2025-08-26 13:40 ` patchwork-bot+bluetooth
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+bluetooth @ 2025-08-26 13:40 UTC (permalink / raw)
  To: Andreas Kemnade; +Cc: linux-bluetooth

Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Tue, 26 Aug 2025 13:43:47 +0200 you wrote:
> When an app is registered and a device gets paired,
> device_set_auto_connect() can be called before the address is resolved.
> Do not ignore the request but rather record the auto connect request so
> that it can be enabled in device_update_addr.
> ---
>  src/device.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)

Here is the summary with links:
  - [BlueZ] device: fix auto connect with private addresses
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=fa2ebfd5fbff

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-08-26 13:39 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-26 11:43 [PATCH BlueZ] device: fix auto connect with private addresses Andreas Kemnade
2025-08-26 13:05 ` [BlueZ] " bluez.test.bot
2025-08-26 13:40 ` [PATCH BlueZ] " patchwork-bot+bluetooth

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).