[PATCH BlueZ v1] shared/shell: Fix not dequeueing command

[PATCH BlueZ v1] shared/shell: Fix not dequeueing command

[Luiz Augusto von Dentz]

From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

If script execution started with command that call
bt_shell_noninteractive_quit directly it wouldn't execute the next
command since data.line wouldn't be set.
---
 src/shared/shell.c | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/src/shared/shell.c b/src/shared/shell.c
index 15f21efef61a..f014d8f7c2b2 100644
--- a/src/shared/shell.c
+++ b/src/shared/shell.c
@@ -269,8 +269,6 @@ static void cmd_export(int argc, char *argv[])
 
 static int bt_shell_queue_exec(char *line)
 {
-	int err;
-
 	/* Ignore comments */
 	if (line[0] == '#')
 		return 0;
@@ -288,12 +286,9 @@ static int bt_shell_queue_exec(char *line)
 	}
 
 	bt_shell_printf("%s\n", line);
+	data.line = strdup(line);
 
-	err = bt_shell_exec(line);
-	if (!err)
-		data.line = strdup(line);
-
-	return err;
+	return bt_shell_exec(line);
 }
 
 static bool bt_shell_input_line(struct input *input)
-- 
2.52.0

RE: [BlueZ,v1] shared/shell: Fix not dequeueing command

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 1622 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=1047149

---Test result---

Test Summary:
CheckPatch                    PENDING   0.38 seconds
GitLint                       PENDING   0.49 seconds
BuildEll                      PASS      20.09 seconds
BluezMake                     PASS      658.01 seconds
MakeCheck                     PASS      18.17 seconds
MakeDistcheck                 PASS      247.03 seconds
CheckValgrind                 PASS      301.05 seconds
CheckSmatch                   WARNING   357.92 seconds
bluezmakeextell               PASS      185.68 seconds
IncrementalBuild              PENDING   0.38 seconds
ScanBuild                     PASS      1048.09 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: CheckSmatch - WARNING
Desc: Run smatch tool with source
Output:
src/shared/shell.c: note: in included file (through /usr/include/readline/readline.h):src/shared/shell.c: note: in included file (through /usr/include/readline/readline.h):src/shared/shell.c: note: in included file (through /usr/include/readline/readline.h):
##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:



---
Regards,
Linux Bluetooth

Re: [PATCH BlueZ v1] shared/shell: Fix not dequeueing command

[patchwork-bot+bluetooth]

Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Mon, 26 Jan 2026 09:47:05 -0500 you wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> 
> If script execution started with command that call
> bt_shell_noninteractive_quit directly it wouldn't execute the next
> command since data.line wouldn't be set.
> ---
>  src/shared/shell.c | 9 ++-------
>  1 file changed, 2 insertions(+), 7 deletions(-)

Here is the summary with links:
  - [BlueZ,v1] shared/shell: Fix not dequeueing command
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=825015d82e2e

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html