public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH BlueZ v2] shared/tmap: Fix TMAP/SR/SGGIT/CHA/BV-01-C on big endian
@ 2026-01-26 16:57 Luiz Augusto von Dentz
  2026-01-26 17:49 ` [BlueZ,v2] " bluez.test.bot
  2026-01-26 17:50 ` [PATCH BlueZ v2] " patchwork-bot+bluetooth
  0 siblings, 2 replies; 3+ messages in thread
From: Luiz Augusto von Dentz @ 2026-01-26 16:57 UTC (permalink / raw)
  To: linux-bluetooth

From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

This fix the following error cause by not converting the role value to
little endian:

TMAP/SR/SGGIT/CHA/BV-01-C [Characteristic GGIT - TMAP Role] - run
**
ERROR:src/shared/tester.c:992:test_io_recv: assertion failed: (memcmp(buf, iov->iov_base, len) == 0)
Bail out! ERROR:src/shared/tester.c:992:test_io_recv: assertion failed: (memcmp(buf, iov->iov_base, len) == 0)
---
 src/shared/tmap.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/shared/tmap.c b/src/shared/tmap.c
index 27e08d74a0d4..696c610aab86 100644
--- a/src/shared/tmap.c
+++ b/src/shared/tmap.c
@@ -239,13 +239,11 @@ static void tmas_role_read(struct gatt_db_attribute *attrib,
 					void *user_data)
 {
 	struct bt_tmas_db *db = user_data;
-	struct iovec iov = {
-		.iov_base = &db->role_value,
-		.iov_len = sizeof(db->role_value)
-	};
+	uint8_t role[2];
 
-	gatt_db_attribute_read_result(attrib, id, 0, iov.iov_base,
-							iov.iov_len);
+	put_le16(db->role_value, role);
+
+	gatt_db_attribute_read_result(attrib, id, 0, role, sizeof(role));
 }
 
 static bool match_db(const void *data, const void *match_data)
-- 
2.52.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* RE: [BlueZ,v2] shared/tmap: Fix TMAP/SR/SGGIT/CHA/BV-01-C on big endian
  2026-01-26 16:57 [PATCH BlueZ v2] shared/tmap: Fix TMAP/SR/SGGIT/CHA/BV-01-C on big endian Luiz Augusto von Dentz
@ 2026-01-26 17:49 ` bluez.test.bot
  2026-01-26 17:50 ` [PATCH BlueZ v2] " patchwork-bot+bluetooth
  1 sibling, 0 replies; 3+ messages in thread
From: bluez.test.bot @ 2026-01-26 17:49 UTC (permalink / raw)
  To: linux-bluetooth, luiz.dentz

[-- Attachment #1: Type: text/plain, Size: 1262 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=1047202

---Test result---

Test Summary:
CheckPatch                    PENDING   0.34 seconds
GitLint                       PENDING   0.41 seconds
BuildEll                      PASS      19.96 seconds
BluezMake                     PASS      640.73 seconds
MakeCheck                     PASS      18.57 seconds
MakeDistcheck                 PASS      240.61 seconds
CheckValgrind                 PASS      292.11 seconds
CheckSmatch                   PASS      348.09 seconds
bluezmakeextell               PASS      181.60 seconds
IncrementalBuild              PENDING   0.28 seconds
ScanBuild                     PASS      1017.07 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:



---
Regards,
Linux Bluetooth


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH BlueZ v2] shared/tmap: Fix TMAP/SR/SGGIT/CHA/BV-01-C on big endian
  2026-01-26 16:57 [PATCH BlueZ v2] shared/tmap: Fix TMAP/SR/SGGIT/CHA/BV-01-C on big endian Luiz Augusto von Dentz
  2026-01-26 17:49 ` [BlueZ,v2] " bluez.test.bot
@ 2026-01-26 17:50 ` patchwork-bot+bluetooth
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+bluetooth @ 2026-01-26 17:50 UTC (permalink / raw)
  To: Luiz Augusto von Dentz; +Cc: linux-bluetooth

Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Mon, 26 Jan 2026 11:57:54 -0500 you wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> 
> This fix the following error cause by not converting the role value to
> little endian:
> 
> TMAP/SR/SGGIT/CHA/BV-01-C [Characteristic GGIT - TMAP Role] - run
> **
> ERROR:src/shared/tester.c:992:test_io_recv: assertion failed: (memcmp(buf, iov->iov_base, len) == 0)
> Bail out! ERROR:src/shared/tester.c:992:test_io_recv: assertion failed: (memcmp(buf, iov->iov_base, len) == 0)
> 
> [...]

Here is the summary with links:
  - [BlueZ,v2] shared/tmap: Fix TMAP/SR/SGGIT/CHA/BV-01-C on big endian
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=521088388bab

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-01-26 17:50 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-26 16:57 [PATCH BlueZ v2] shared/tmap: Fix TMAP/SR/SGGIT/CHA/BV-01-C on big endian Luiz Augusto von Dentz
2026-01-26 17:49 ` [BlueZ,v2] " bluez.test.bot
2026-01-26 17:50 ` [PATCH BlueZ v2] " patchwork-bot+bluetooth

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox