public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH BlueZ 0/1] adapter: Fix "Failed to set default system config" startup warning
@ 2026-03-19 10:52 Bastien Nocera
  2026-03-19 10:52 ` [PATCH BlueZ 1/1] " Bastien Nocera
  2026-03-19 17:50 ` [PATCH BlueZ 0/1] " patchwork-bot+bluetooth
  0 siblings, 2 replies; 4+ messages in thread
From: Bastien Nocera @ 2026-03-19 10:52 UTC (permalink / raw)
  To: linux-bluetooth; +Cc: Stefan Sørensen

I wonder if the original report swapped one warning for another, or if
the problem didn't happen for the majority of folks due to command
processing in hardware specific drivers/firmware.

Regression test added to the meson tree:
https://github.com/hadess/bluez/blob/wip/hadess/add-meson-ell-wrap/unit/integration-test.py#L215

Bastien Nocera (1):
  adapter: Fix "Failed to set default system config" startup warning

 src/adapter.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

-- 
2.53.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH BlueZ 1/1] adapter: Fix "Failed to set default system config" startup warning
  2026-03-19 10:52 [PATCH BlueZ 0/1] adapter: Fix "Failed to set default system config" startup warning Bastien Nocera
@ 2026-03-19 10:52 ` Bastien Nocera
  2026-03-19 12:37   ` bluez.test.bot
  2026-03-19 17:50 ` [PATCH BlueZ 0/1] " patchwork-bot+bluetooth
  1 sibling, 1 reply; 4+ messages in thread
From: Bastien Nocera @ 2026-03-19 10:52 UTC (permalink / raw)
  To: linux-bluetooth; +Cc: Stefan Sørensen

When using a stock configuration, there will be nothing in the list of
configuration changes to apply to the Bluetooth adapter, which since
5e5b46c5c0cc ("adapter: Do not send empty default system parameter
list") would throw an error, as sending an empty list to the adapter
didn't generate one.

bluetoothd[3291147]: Bluetooth daemon 5.86
bluetoothd[3291147]: Starting SDP server
bluetoothd[3291147]: Using external plugins is not officially supported.
bluetoothd[3291147]: Consider upstreaming your plugins into the BlueZ project.
bluetoothd[3291147]: Bluetooth management interface 1.23 initialized
bluetoothd[3291147]: Battery Provider Manager created
bluetoothd[3291147]: Failed to set default system config for hci0

Fixes: 5e5b46c5c0cc ("adapter: Do not send empty default system parameter list")
---
 src/adapter.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/src/adapter.c b/src/adapter.c
index 4e5ff219fe8b..04568dae6e98 100644
--- a/src/adapter.c
+++ b/src/adapter.c
@@ -4963,8 +4963,11 @@ static void load_defaults(struct btd_adapter *adapter)
 	if (!load_le_defaults(adapter, list, &btd_opts.defaults.le))
 		goto done;
 
-	if (mgmt_tlv_list_size(list) == 0)
-		goto done;
+	/* No changes from defaults */
+	if (mgmt_tlv_list_size(list) == 0) {
+		mgmt_tlv_list_free(list);
+		return;
+	}
 
 	err = mgmt_send_tlv(adapter->mgmt, MGMT_OP_SET_DEF_SYSTEM_CONFIG,
 			adapter->dev_id, list, NULL, NULL, NULL);
-- 
2.53.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* RE: adapter: Fix "Failed to set default system config" startup warning
  2026-03-19 10:52 ` [PATCH BlueZ 1/1] " Bastien Nocera
@ 2026-03-19 12:37   ` bluez.test.bot
  0 siblings, 0 replies; 4+ messages in thread
From: bluez.test.bot @ 2026-03-19 12:37 UTC (permalink / raw)
  To: linux-bluetooth, hadess

[-- Attachment #1: Type: text/plain, Size: 1311 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=1069215

---Test result---

Test Summary:
CheckPatch                    PENDING   0.65 seconds
GitLint                       PENDING   0.60 seconds
BuildEll                      PASS      21.09 seconds
BluezMake                     PASS      656.26 seconds
MakeCheck                     PASS      18.46 seconds
MakeDistcheck                 PASS      247.29 seconds
CheckValgrind                 PASS      291.74 seconds
CheckSmatch                   PASS      359.31 seconds
bluezmakeextell               PASS      181.70 seconds
IncrementalBuild              PENDING   0.49 seconds
ScanBuild                     PASS      1045.96 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:



https://github.com/bluez/bluez/pull/1972/checks

---
Regards,
Linux Bluetooth


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH BlueZ 0/1] adapter: Fix "Failed to set default system config" startup warning
  2026-03-19 10:52 [PATCH BlueZ 0/1] adapter: Fix "Failed to set default system config" startup warning Bastien Nocera
  2026-03-19 10:52 ` [PATCH BlueZ 1/1] " Bastien Nocera
@ 2026-03-19 17:50 ` patchwork-bot+bluetooth
  1 sibling, 0 replies; 4+ messages in thread
From: patchwork-bot+bluetooth @ 2026-03-19 17:50 UTC (permalink / raw)
  To: Bastien Nocera; +Cc: linux-bluetooth, ssorensen

Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Thu, 19 Mar 2026 11:52:05 +0100 you wrote:
> I wonder if the original report swapped one warning for another, or if
> the problem didn't happen for the majority of folks due to command
> processing in hardware specific drivers/firmware.
> 
> Regression test added to the meson tree:
> https://github.com/hadess/bluez/blob/wip/hadess/add-meson-ell-wrap/unit/integration-test.py#L215
> 
> [...]

Here is the summary with links:
  - [BlueZ,1/1] adapter: Fix "Failed to set default system config" startup warning
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=b9a72fef5cd5

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-03-19 17:50 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-19 10:52 [PATCH BlueZ 0/1] adapter: Fix "Failed to set default system config" startup warning Bastien Nocera
2026-03-19 10:52 ` [PATCH BlueZ 1/1] " Bastien Nocera
2026-03-19 12:37   ` bluez.test.bot
2026-03-19 17:50 ` [PATCH BlueZ 0/1] " patchwork-bot+bluetooth

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox