[PATCH BlueZ v1] advertising: Fix sending extra bytes with MGMT_OP_ADD_EXT_ADV_DATA

[PATCH BlueZ v1] advertising: Fix sending extra bytes with MGMT_OP_ADD_EXT_ADV_DATA

[Luiz Augusto von Dentz]

From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

MGMT_OP_ADD_EXT_ADV_DATA expects the command to be of size of
struct mgmt_cp_add_ext_adv_data not mgmt_cp_add_advertising.
---
 src/advertising.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/advertising.c b/src/advertising.c
index c8b00a887911..1ed09c902b4b 100644
--- a/src/advertising.c
+++ b/src/advertising.c
@@ -1498,8 +1498,7 @@ static void add_adv_params_callback(uint8_t status, uint16_t length,
 		}
 	}
 
-	param_len = sizeof(struct mgmt_cp_add_advertising) + adv_data_len +
-							scan_rsp_len;
+	param_len = sizeof(*cp) + adv_data_len + scan_rsp_len;
 
 	cp = malloc0(param_len);
 	if (!cp) {
-- 
2.54.0

RE: [BlueZ,v1] advertising: Fix sending extra bytes with MGMT_OP_ADD_EXT_ADV_DATA

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 1192 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=1104846

---Test result---

Test Summary:
CheckPatch                    PASS      2.26 seconds
GitLint                       PASS      0.37 seconds
BuildEll                      PASS      20.58 seconds
BluezMake                     PASS      696.31 seconds
CheckSmatch                   WARNING   355.44 seconds
bluezmakeextell               PASS      182.82 seconds
IncrementalBuild              PASS      668.57 seconds
ScanBuild                     PASS      1026.46 seconds

Details
##############################
Test: CheckSmatch - WARNING
Desc: Run smatch tool with source
Output:
src/advertising.c: note: in included file:./src/shared/mgmt.h:95:25: error: redefinition of unsigned int enum mgmt_io_capabilitysrc/advertising.c: note: in included file:./src/shared/mgmt.h:95:25: error: redefinition of unsigned int enum mgmt_io_capability


https://github.com/bluez/bluez/pull/2167

---
Regards,
Linux Bluetooth

Re: [PATCH BlueZ v1] advertising: Fix sending extra bytes with MGMT_OP_ADD_EXT_ADV_DATA

[patchwork-bot+bluetooth]

Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Tue,  2 Jun 2026 16:47:49 -0400 you wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> 
> MGMT_OP_ADD_EXT_ADV_DATA expects the command to be of size of
> struct mgmt_cp_add_ext_adv_data not mgmt_cp_add_advertising.
> ---
>  src/advertising.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Here is the summary with links:
  - [BlueZ,v1] advertising: Fix sending extra bytes with MGMT_OP_ADD_EXT_ADV_DATA
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=2a6968b40378

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html