From: patchwork-bot+bluetooth@kernel.org
To: Linmao Li <lilinmao@kylinos.cn>
Cc: marcel@holtmann.org, luiz.dentz@gmail.com, brian.gix@intel.com,
linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH bluetooth 0/4] Bluetooth: fix cmd_sync payload lifetimes on the cancel path
Date: Thu, 06 Aug 2026 19:54:59 +0000 [thread overview]
Message-ID: <178604609963.1449574.15912669243758957129.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20260806125957.698760-1-lilinmao@kylinos.cn>
Hello:
This series was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:
On Thu, 6 Aug 2026 20:59:53 +0800 you wrote:
> The cmd_sync worker calls entry->destroy() after running a command, and
> _hci_cmd_sync_cancel_entry() does the same when an entry is cancelled --
> but only if a destroy callback was supplied. Without one it frees the
> work entry and leaves entry->data unreleased.
>
> These four call sites pass a heap payload with a NULL destroy callback
> and free it inside the sync function instead, so each of them leaks when
> the entry is cancelled rather than run. hci_cmd_sync_clear() cancels
> every pending entry when the controller is unregistered.
>
> [...]
Here is the summary with links:
- [1/4] Bluetooth: hci_conn: fix the SCO setup context lifetime
https://git.kernel.org/bluetooth/bluetooth-next/c/7645e748704a
- [2/4] Bluetooth: hci_sync: free the advertising instance on the failure and cancel paths
https://git.kernel.org/bluetooth/bluetooth-next/c/19aa86a8d171
- [3/4] Bluetooth: MGMT: free the mesh send cancel command when it is cancelled
https://git.kernel.org/bluetooth/bluetooth-next/c/ac0965fb4b86
- [4/4] Bluetooth: MGMT: free the HCI command when it is cancelled
https://git.kernel.org/bluetooth/bluetooth-next/c/f2afd8eadf5d
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2026-08-06 19:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-06 12:59 [PATCH bluetooth 0/4] Bluetooth: fix cmd_sync payload lifetimes on the cancel path Linmao Li
2026-08-06 12:59 ` [PATCH bluetooth 1/4] Bluetooth: hci_conn: fix the SCO setup context lifetime Linmao Li
2026-08-06 14:15 ` Bluetooth: fix cmd_sync payload lifetimes on the cancel path bluez.test.bot
2026-08-06 12:59 ` [PATCH bluetooth 2/4] Bluetooth: hci_sync: free the advertising instance on the failure and cancel paths Linmao Li
2026-08-06 12:59 ` [PATCH bluetooth 3/4] Bluetooth: MGMT: free the mesh send cancel command when it is cancelled Linmao Li
2026-08-06 12:59 ` [PATCH bluetooth 4/4] Bluetooth: MGMT: free the HCI " Linmao Li
2026-08-06 19:54 ` patchwork-bot+bluetooth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178604609963.1449574.15912669243758957129.git-patchwork-notify@kernel.org \
--to=patchwork-bot+bluetooth@kernel.org \
--cc=brian.gix@intel.com \
--cc=lilinmao@kylinos.cn \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox