From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D0DB646DFFC; Mon, 31 Aug 2026 17:21:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788196869; cv=none; b=akye4xYyPM740bbL3avJS5sULtKdWUUPuv8GoK9OVKokCbZogwNEs0fXF/0TGSAfJ3rM0DM8FxIzteWhETmyczSKldJgAvyRkM5YUccUzIZzNLSw0r0Cz2j23bSXZW2hWuNkxgQldjqidCvGZ2+A3Q7a7brY1VZ7VPfIax4a84M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788196869; c=relaxed/simple; bh=GvwcNznV1DlYse4XBICTIxh5gO4Aoe2MUFUMv4bTMO8=; h=Content-Type:MIME-Version:Subject:From:Message-Id:Date:References: In-Reply-To:To:Cc; b=kAUKc78ZSBvKStq76etS7ZoKXk/oJ78aFH9Zu6xvccHV35Z26I7V04sy+1N4nDbJzOKv3T+XQrxxmkKwyhH06f/6CDrUrs47ikY0W2RjV/+5eG2vIO+kK2wlcfZL95cHpecNeuRQC9+nDCoWJ2OqnigGOk7H2goBrHiH+Nibn3Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=hoTsXRTy; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="hoTsXRTy" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B80CC1F000E9; Mon, 31 Aug 2026 17:21:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1788196867; bh=TsG8zO0WGO0tWo5gEehJ9QLyHohlP24EniCH2k8MKq4=; h=Subject:From:Date:References:In-Reply-To:To:Cc; b=hoTsXRTywCzu6xN7/OW3Z5XgozMiswz+g2gIND79UFnx/VKprlJcS9z8i+z/BIoQu WB+43PHNMJzlEUvHiQFxpjoJ29dFxn+nNixA3nDtmVE1GWwAXbFSfogezzad4E9pnD 5/HEHj0RP1zr76HHyDsbtfQV/Witl+VslVzLmSs4TsGraJC+yLOJFPYASY/2BONL7h GRWbvKU0fkc9Y2bqIdPKyQSNIeKQN6jTGi9lgfCIRp0r7OP+vC+x0hIoqyPcwODEjB Fq7Rc4WiIiBFvGPugoOgApF/4EZY3RrxiyvRbZz243AfaMcWLsFadRWZU6UdEthQ3K ifEDDoTeSRP4Q== Received: from [10.30.226.235] (localhost [IPv6:::1]) by aws-us-west-2-korg-oddjob-rhel9-1.codeaurora.org (Postfix) with ESMTP id 1972A3924458; Mon, 31 Aug 2026 17:20:12 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-bluetooth@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH v2] Bluetooth: hci_mrvl: Fix wrong return value check of wait_on_bit_timeout() From: patchwork-bot+bluetooth@kernel.org Message-Id: <178819681074.671757.16650865347821442609.git-patchwork-notify@kernel.org> Date: Mon, 31 Aug 2026 17:20:10 +0000 References: <20260825020145.2840983-1-13875017792@163.com> In-Reply-To: <20260825020145.2840983-1-13875017792@163.com> To: Gongwei Li <13875017792@163.com> Cc: marcel@holtmann.org, luiz.dentz@gmail.com, loic.poulain@oss.qualcomm.com, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, ligongwei@kylinos.cn Hello: This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz : On Tue, 25 Aug 2026 10:01:45 +0800 you wrote: > From: Gongwei Li > > wait_on_bit_timeout() returns 0 if the bit was cleared, -EINTR if the > process received a signal and the mode permitted wake up on that signal, > or -EAGAIN if the timeout elapsed. It never returns 1. > > Hence the check "err == 1" in mrvl_load_firmware() is dead code: when > the waiting task is interrupted by a signal (-EINTR), the code falls > into the "else if (err)" branch and misreports it as "Firmware request > timeout" with -ETIMEDOUT instead of propagating -EINTR. > > [...] Here is the summary with links: - [v2] Bluetooth: hci_mrvl: Fix wrong return value check of wait_on_bit_timeout() https://git.kernel.org/bluetooth/bluetooth-next/c/870187be2362 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html