Linux bluetooth development
 help / color / mirror / Atom feed
From: patchwork-bot+bluetooth@kernel.org
To: Iaroslav Voitovych <yaroslav.voytovych@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH BlueZ 1/2] shared/mgmt: Fix notify leak in mgmt_unregister()
Date: Thu, 08 Oct 2026 15:20:04 +0000	[thread overview]
Message-ID: <179147280477.313948.6286426737429078397.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20261008034102.707451-1-yaroslav.voytovych@gmail.com>

Hello:

This series was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Thu,  8 Oct 2026 05:41:01 +0200 you wrote:
> mgmt_unregister() called from a notification callback takes the entry
> off notify_list and marks it removed instead of freeing it.
> process_notify() frees the removed entries still on notify_list once
> the walk is done, so this one is never freed and its destroy callback
> never runs.
> 
> If the callback unregisters the next entry rather than its own, this
> is also a use-after-free: queue_foreach() has already saved that
> entry's queue node, and queue_remove_if() frees it. That is the crash
> fixed for mgmt_unregister_index() by commit 872729a91632
> ("shared/mgmt: Fix crash when removing index"), still present in
> mgmt_unregister().
> 
> [...]

Here is the summary with links:
  - [BlueZ,1/2] shared/mgmt: Fix notify leak in mgmt_unregister()
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=ae23df052290
  - [BlueZ,2/2] unit/test-mgmt: Test unregistering from callbacks
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=6f5eeb402d3b

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



      parent reply	other threads:[~2026-10-08 15:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-08  3:41 [PATCH BlueZ 1/2] shared/mgmt: Fix notify leak in mgmt_unregister() Iaroslav Voitovych
2026-10-08  3:41 ` [PATCH BlueZ 2/2] unit/test-mgmt: Test unregistering from callbacks Iaroslav Voitovych
2026-10-08 10:41 ` [BlueZ,1/2] shared/mgmt: Fix notify leak in mgmt_unregister() bluez.test.bot
2026-10-08 15:20 ` patchwork-bot+bluetooth [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179147280477.313948.6286426737429078397.git-patchwork-notify@kernel.org \
    --to=patchwork-bot+bluetooth@kernel.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=yaroslav.voytovych@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox