Linux bluetooth development
 help / color / mirror / Atom feed
From: patchwork-bot+bluetooth@kernel.org
To: Weihong Guan <weihong.guan@gmail.com>
Cc: linux-bluetooth@vger.kernel.org, marcel@holtmann.org,
	luiz.dentz@gmail.com
Subject: Re: [PATCH] Bluetooth: hci_sync: Drop the command's sk reference
Date: Thu, 12 Nov 2026 20:20:06 +0000	[thread overview]
Message-ID: <179451480627.628769.17407039026686649697.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20261112033428.898540-1-weihong.guan@gmail.com>

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Thu, 12 Nov 2026 03:34:28 +0000 you wrote:
> hci_cmd_sync_alloc() takes a reference on the sk a command is sent for
> (sock_hold()), and hci_cmd_sync_complete() means to drop it, but looks
> for the sk in the response skb, which never carries one. The reference
> is never dropped: every command sent with an sk leaks it, and with it
> the sk and a reference on the bluetooth module.
> 
> The commands sent with an sk are LE Remove Advertising Set and LE
> Clear Advertising Sets, for MGMT's Remove Advertising and the instance
> removals, and Read Local OOB (Extended) Data. After each, the module's
> refcnt stays one higher with no socket left open, and the module can't
> be unloaded until a reboot.
> 
> [...]

Here is the summary with links:
  - Bluetooth: hci_sync: Drop the command's sk reference
    https://git.kernel.org/bluetooth/bluetooth-next/c/f3183d7ad101

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



      parent reply	other threads:[~2026-11-12 20:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-12  3:34 [PATCH] Bluetooth: hci_sync: Drop the command's sk reference Weihong Guan
2026-11-12  5:01 ` bluez.test.bot
2026-11-12 20:20 ` patchwork-bot+bluetooth [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179451480627.628769.17407039026686649697.git-patchwork-notify@kernel.org \
    --to=patchwork-bot+bluetooth@kernel.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    --cc=marcel@holtmann.org \
    --cc=weihong.guan@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox