From: patchwork-bot+bluetooth@kernel.org
To: Tzung-Bi Shih <tzungbi@kernel.org>
Cc: marcel@holtmann.org, luiz.dentz@gmail.com, max.chou@realtek.com,
linux-bluetooth@vger.kernel.org, tfiga@chromium.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v2 0/2] Bluetooth: btrtl: Fix NULL return on errors in btrtl_initialize()
Date: Thu, 19 Nov 2026 18:50:07 +0000 [thread overview]
Message-ID: <179511420733.3743161.1888737096932815865.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20261119032415.4010732-1-tzungbi@kernel.org>
Hello:
This series was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:
On Thu, 19 Nov 2026 03:24:13 +0000 you wrote:
> In btrtl_initialize(), the `err_free` error path frees `btrtl_dev` and
> returns `ERR_PTR(ret)`. Because earlier calls in btrtl_initialize() set
> `ret` to 0 on success, any subsequent failure path that jumps to
> `err_free` without setting `ret` to a negative error code causes
> btrtl_initialize() to return `ERR_PTR(0)` (`NULL`).
>
> Since the caller btrtl_setup_realtek() only checks `IS_ERR(btrtl_dev)`,
> a `NULL` return bypasses the error check and causes a NULL pointer
> dereference in btrtl_download_firmware().
>
> [...]
Here is the summary with links:
- [v2,1/2] Bluetooth: btrtl: Propagate errors if btrtl_vendor_read_reg16() fails
https://git.kernel.org/bluetooth/bluetooth-next/c/c3cdaaa5cb5b
- [v2,2/2] Bluetooth: btrtl: Return -ENOMEM if bt_skb_alloc() fails
https://git.kernel.org/bluetooth/bluetooth-next/c/fc4527d1e1b6
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2026-11-19 18:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 3:24 [PATCH v2 0/2] Bluetooth: btrtl: Fix NULL return on errors in btrtl_initialize() Tzung-Bi Shih
2026-11-19 3:24 ` [PATCH v2 1/2] Bluetooth: btrtl: Propagate errors if btrtl_vendor_read_reg16() fails Tzung-Bi Shih
2026-11-19 8:15 ` Bluetooth: btrtl: Fix NULL return on errors in btrtl_initialize() bluez.test.bot
2026-11-19 3:24 ` [PATCH v2 2/2] Bluetooth: btrtl: Return -ENOMEM if bt_skb_alloc() fails Tzung-Bi Shih
2026-11-19 18:50 ` patchwork-bot+bluetooth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179511420733.3743161.1888737096932815865.git-patchwork-notify@kernel.org \
--to=patchwork-bot+bluetooth@kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=max.chou@realtek.com \
--cc=stable@vger.kernel.org \
--cc=tfiga@chromium.org \
--cc=tzungbi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox