From: Szymon Janc <szymon.janc@tieto.com>
To: Marcin Kraglak <marcin.kraglak@tieto.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 1/3] android/gatt: Fix reading attribute value
Date: Fri, 16 May 2014 10:45:35 +0200 [thread overview]
Message-ID: <18188176.R3cMoBMcFL@uw000953> (raw)
In-Reply-To: <1400229459-21617-1-git-send-email-marcin.kraglak@tieto.com>
Hi Marcin,
On Friday 16 of May 2014 10:37:37 Marcin Kraglak wrote:
> If value and length was set by callback while gatt_db_read(), don't set
> length to READ_PENDING. We have to set it only for async callbacks, then
> length is still READ_INIT.
> ---
> android/gatt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/android/gatt.c b/android/gatt.c
> index b367eef..2a2e649 100644
> --- a/android/gatt.c
> +++ b/android/gatt.c
> @@ -3670,7 +3670,7 @@ static void read_requested_attributes(void *data, void *user_data)
>
> memcpy(resp_data->value, value, value_len);
> resp_data->length = value_len;
> - } else {
> + } else if (resp_data->length == READ_INIT) {
> resp_data->length = READ_PENDING;
> }
> }
>
All patches applied, thanks.
--
Best regards,
Szymon Janc
prev parent reply other threads:[~2014-05-16 8:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-16 8:37 [PATCH 1/3] android/gatt: Fix reading attribute value Marcin Kraglak
2014-05-16 8:37 ` [PATCH 2/3] android/gatt: Set length to READ_INIT before read request Marcin Kraglak
2014-05-16 8:37 ` [PATCH 3/3] android/gatt: Don't try send responses after process_dev_pending_req() Marcin Kraglak
2014-05-16 8:45 ` Szymon Janc [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18188176.R3cMoBMcFL@uw000953 \
--to=szymon.janc@tieto.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcin.kraglak@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox