Re: [PATCH BlueZ 2/3] tools/btpclient: Add connect, disconnect commands

[Szymon Janc <szymon.janc@codecoup.pl>]

Hi Johan,

On Wednesday, 10 January 2018 13:25:27 CET Johan Hedberg wrote:
> Hi Szymon,
> 
> On Wed, Jan 10, 2018, Szymon Janc wrote:
> > On Wednesday, 10 January 2018 12:24:56 CET Johan Hedberg wrote:
> > > On Wed, Jan 10, 2018, Szymon Janc wrote:
> > > > On Tuesday, 9 January 2018 16:45:20 CET Grzegorz Kolodziejczyk wrote:
> > > > > +static bool addr2str(const uint8_t *addr, char *str)
> > > > > +{
> > > > > +	return sprintf(str, "%02hhX:%02hhX:%02hhX:%02hhX:%02hhX:%02hhX",
> > > > > +			addr[0], addr[1], addr[2], addr[3], addr[4], addr[5])
> > > > > +			== 17;
> > > > > +}
> > > > 
> > > > Use snprintf.
> > > 
> > > Why isn't this tool using the address conversion helpers from
> > > lib/bluetooth.c?
> > 
> > This is BTP address and has different byte order.
> 
> Hmm... I'm a bit confused now. I thought BTP is little endian like HCI
> and most Bluetooth protocols. At least that's what it says here:
> 
> https://github.com/zephyrproject-rtos/zephyr/blob/master/tests/bluetooth/tes
> ter/btp_spec.txt#L58
> 
> What am I missing? :)

Yes, you're correct. This needs fixing, although we would have to link against 
libbluetooth only for those sprintf wrappers.. (especially that those use 
insecure variant of printf).

-- 
pozdrawiam
Szymon Janc