From: Szymon Janc <szymon.janc@tieto.com>
To: Andrei Emeltchenko <Andrei.Emeltchenko.news@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] android/gatt: Fix memory leak
Date: Wed, 24 Dec 2014 12:16:33 +0100 [thread overview]
Message-ID: <1962912.3sVAV770nz@leonov> (raw)
In-Reply-To: <1418997020-7293-1-git-send-email-Andrei.Emeltchenko.news@gmail.com>
Hi Andrei,
On Friday 19 of December 2014 15:50:20 Andrei Emeltchenko wrote:
> From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
>
> ---
> android/gatt.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/android/gatt.c b/android/gatt.c
> index 2534836..6248f07 100644
> --- a/android/gatt.c
> +++ b/android/gatt.c
> @@ -6129,6 +6129,7 @@ static uint8_t find_info_handle(const uint8_t *cmd,
> uint16_t cmd_len, int iterator = 0;
> uint16_t start, end;
> uint16_t len, queue_len;
> + uint8_t ret = 0;
>
> DBG("");
>
> @@ -6206,13 +6207,13 @@ static uint8_t find_info_handle(const uint8_t *cmd,
> uint16_t cmd_len, ATT_FIND_INFO_RESP_FMT_128BIT, adl, rsp,
> rsp_size);
> if (!len)
> - return ATT_ECODE_UNLIKELY;
> + ret = ATT_ECODE_UNLIKELY;
>
> *length = len;
> att_data_list_free(adl);
> queue_destroy(temp, NULL);
>
> - return 0;
> + return ret;
> }
>
> static uint8_t find_by_type_request(const uint8_t *cmd, uint16_t cmd_len,
Applied, thanks.
--
BR
Szymon Janc
next prev parent reply other threads:[~2014-12-24 11:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-19 13:50 [PATCH] android/gatt: Fix memory leak Andrei Emeltchenko
2014-12-24 11:16 ` Szymon Janc [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-07-03 11:32 Andrei Emeltchenko
2014-04-12 21:48 Lukasz Rymanowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1962912.3sVAV770nz@leonov \
--to=szymon.janc@tieto.com \
--cc=Andrei.Emeltchenko.news@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).