From: Szymon Janc <szymon.janc@tieto.com>
To: Grzegorz Kolodziejczyk <grzegorz.kolodziejczyk@tieto.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 1/8] android/gatt: Fix return status if cannot alloc memory
Date: Fri, 24 Oct 2014 14:18:09 +0200 [thread overview]
Message-ID: <1970231.pCIHQJfjbF@uw000953> (raw)
In-Reply-To: <1413553099-19689-1-git-send-email-grzegorz.kolodziejczyk@tieto.com>
Hi Grzegorz,
On Friday 17 of October 2014 15:38:12 Grzegorz Kolodziejczyk wrote:
> NOMEM HAL status should be returned in case if it's not possible to
> alloc memory for notifiaction data.
> ---
> android/gatt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/android/gatt.c b/android/gatt.c
> index ea20941..c26d45a 100644
> --- a/android/gatt.c
> +++ b/android/gatt.c
> @@ -3759,7 +3759,7 @@ static void handle_client_register_for_notification(const void *buf,
>
> notification = new0(struct notification_data, 1);
> if (!notification) {
> - status = HAL_STATUS_FAILED;
> + status = HAL_STATUS_NOMEM;
> goto failed;
> }
>
All patches have been applied. Thanks.
--
Best regards,
Szymon Janc
prev parent reply other threads:[~2014-10-24 12:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-17 13:38 [PATCH 1/8] android/gatt: Fix return status if cannot alloc memory Grzegorz Kolodziejczyk
2014-10-17 13:38 ` [PATCH 2/8] android/tester: Define write types for GATT test cases Grzegorz Kolodziejczyk
2014-10-17 13:38 ` [PATCH 3/8] android/tester: Fix hardcoded length values Grzegorz Kolodziejczyk
2014-10-17 13:38 ` [PATCH 4/8] android/tester: Use BT_STATUS defines instead of hardcoded values Grzegorz Kolodziejczyk
2014-10-17 13:38 ` [PATCH 5/8] android/tester: Add att pdu remote receive debug log Grzegorz Kolodziejczyk
2014-10-17 13:38 ` [PATCH 6/8] android/tester: Add GATT server send indication test cases Grzegorz Kolodziejczyk
2014-10-17 13:38 ` [PATCH 7/8] android/tester: Add GATT server send response to read req " Grzegorz Kolodziejczyk
2014-10-17 13:38 ` [PATCH 8/8] android/tester: Add GATT server send response to write " Grzegorz Kolodziejczyk
2014-10-24 12:18 ` Szymon Janc [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1970231.pCIHQJfjbF@uw000953 \
--to=szymon.janc@tieto.com \
--cc=grzegorz.kolodziejczyk@tieto.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox