Linux bluetooth development
 help / color / mirror / Atom feed
From: Szymon Janc <szymon.janc@tieto.com>
To: Grzegorz Kolodziejczyk <grzegorz.kolodziejczyk@tieto.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v2 1/3] android/gatt: Remove unused uuid variable
Date: Fri, 04 Apr 2014 10:30:39 +0200	[thread overview]
Message-ID: <19956629.7zao5MFIZu@uw000953> (raw)
In-Reply-To: <1396596720-13779-1-git-send-email-grzegorz.kolodziejczyk@tieto.com>

Hi Grzegorz,

On Friday 04 of April 2014 09:31:58 Grzegorz Kolodziejczyk wrote:
> This patch removes unused uuid string variable.
> ---
>  android/gatt.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/android/gatt.c b/android/gatt.c
> index 7a6a2a2..68e2112 100644
> --- a/android/gatt.c
> +++ b/android/gatt.c
> @@ -2215,7 +2215,6 @@ static void handle_client_register_for_notification(const void *buf,
>  {
>  	const struct hal_cmd_gatt_client_register_for_notification *cmd = buf;
>  	struct notification_data *notification;
> -	char uuid[MAX_LEN_UUID_STR];
>  	struct gatt_client *client;
>  	struct characteristic *c;
>  	struct element_id match_id;
> @@ -2247,7 +2246,6 @@ static void handle_client_register_for_notification(const void *buf,
>  	hal_srvc_id_to_element_id(&cmd->srvc_id, &match_id);
>  	service = queue_find(dev->services, match_srvc_by_element_id,
>  								&match_id);
> -	bt_uuid_to_string(&match_id.uuid, uuid, MAX_LEN_UUID_STR);
>  	if (!service) {
>  		status = HAL_STATUS_FAILED;
>  		goto failed;
> 

All patches applied, thanks.

-- 
Best regards, 
Szymon Janc

      parent reply	other threads:[~2014-04-04  8:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-04  7:31 [PATCH v2 1/3] android/gatt: Remove unused uuid variable Grzegorz Kolodziejczyk
2014-04-04  7:31 ` [PATCH v2 2/3] android/gatt: Remove useless variable cast Grzegorz Kolodziejczyk
2014-04-04  7:32 ` [PATCH v2 3/3] android/gatt: Fix matching characteristict Grzegorz Kolodziejczyk
2014-04-04  8:30 ` Szymon Janc [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=19956629.7zao5MFIZu@uw000953 \
    --to=szymon.janc@tieto.com \
    --cc=grzegorz.kolodziejczyk@tieto.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox