Re: [PATCH 3/3] AVRCP: Add Passthrough Signal

["David Stockwell" <dstockwell@frequency-one.com>]

Hello, Luiz

-----Original Message----- 
From: Luiz Augusto von Dentz
Sent: Thursday, August 25, 2011 2:44 AM
To: David Stockwell
Cc: linux-bluetooth@vger.kernel.org ; johan.hedberg@gmail.com
Subject: Re: [PATCH 3/3] AVRCP: Add Passthrough Signal

Hi David,

On Thu, Aug 25, 2011 at 2:58 AM, David Stockwell
<dstockwell@frequency-one.com> wrote:
> +++++ OK, maybe a readwrite Passthrough property indicating how 
> passthroughs
> are handled: Signal, Uinput, Both, None?  Or simply a PassthruSignal
> property (true/false, default false), given that the presence/absence of
> /dev/uinput handles the other case?
>
> I really think the Control should emit the signal...since it comes from a 
> CT
> (and not really from a MediaPlayer or somesuch).

You are missing a very important point here, parsing of these vendor
specific commands would have to be split to each target thus we cannot
guarantee a consistent handling of them, if we stick to uinput I think
we should use KEY_VENDOR, otherwise we should send the commands
directly to the player.

+++++
Actually, I expected that the routing of these passthroughs would be handled 
outside BlueZ, from Control(s) to (whatever) media playing app(s) in a 
supervisory app/daemon.  Whether the signal is issued from the Control or 
from the MediaPlayer interface is not significant to me; an easy code change 
in the patch and in my supervisory app.  Any additional thoughts or 
comments?
+++++
-- 
Luiz Augusto von Dentz