linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [Bluez-devel] I've found a bug in sdp_cstate_get() function.
@ 2008-03-19 16:03 이주영
  2008-03-19 16:47 ` Marcel Holtmann
  0 siblings, 1 reply; 6+ messages in thread
From: 이주영 @ 2008-03-19 16:03 UTC (permalink / raw)
  To: bluez-devel


[-- Attachment #1.1: Type: text/plain, Size: 457 bytes --]

Hi,
 
I've found a bug in sdp_cstate_get() function.
(bluez-utils/dist/sdpd/request.c)
 -> memcpy(cstate, (sdp_cont_state_t *)pdata, sizeof(sdp_cont_state_t));
When running this code, "hcid daemon crash" occurred.(memory alignment error)
I think there's a bug with (sdp_cont_state_t *)pdata in sdp_cstate_get() function.
I fixed this code.
 -> memcpy(cstate, pdata, sizeof(sdp_cont_state_t));
Now, hcid daemon doesn't die.
 
 
tkakel님의 블로그
안녕하세요.

[-- Attachment #1.2: Type: text/html, Size: 2739 bytes --]

[-- Attachment #2: Type: text/plain, Size: 228 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

[-- Attachment #3: Type: text/plain, Size: 164 bytes --]

_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Bluez-devel] I've found a bug in sdp_cstate_get() function.
  2008-03-19 16:03 [Bluez-devel] I've found a bug in sdp_cstate_get() function 이주영
@ 2008-03-19 16:47 ` Marcel Holtmann
  2008-03-20  4:01   ` 이주영
  2008-03-20 11:22   ` [Bluez-devel] RFCOMM sockets Fabrizio Guglielmino
  0 siblings, 2 replies; 6+ messages in thread
From: Marcel Holtmann @ 2008-03-19 16:47 UTC (permalink / raw)
  To: 이주영, BlueZ development

Hi,

> I've found a bug in sdp_cstate_get() function.
> (bluez-utils/dist/sdpd/request.c)
>  -> memcpy(cstate, (sdp_cont_state_t *)pdata,  
> sizeof(sdp_cont_state_t));
> When running this code, "hcid daemon crash" occurred.(memory  
> alignment error)
>
> I think there's a bug with (sdp_cont_state_t *)pdata in  
> sdp_cstate_get() function.
> I fixed this code.
>  -> memcpy(cstate, pdata, sizeof(sdp_cont_state_t));
> Now, hcid daemon doesn't die.
>

which version? This should have been fixed by now. Either in the  
latest bluez-utils-3.28 or the CVS.

Regards

Marcel


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* RE: Re: [Bluez-devel] I've found a bug in sdp_cstate_get() function.
  2008-03-19 16:47 ` Marcel Holtmann
@ 2008-03-20  4:01   ` 이주영
  2008-03-20 12:43     ` Marcel Holtmann
  2008-03-20 11:22   ` [Bluez-devel] RFCOMM sockets Fabrizio Guglielmino
  1 sibling, 1 reply; 6+ messages in thread
From: 이주영 @ 2008-03-20  4:01 UTC (permalink / raw)
  To: Marcel Holtmann, bluez-devel

[-- Attachment #1: Type: text/plain, Size: 962 bytes --]

Hi,
 
The version is latest bluez-utils-3.28.
 
Thanks.
 
Regards
jooyoung.
 
-----Original Message-----
From: "Marcel Holtmann"<marcel@holtmann.org> 
To: "이주영"<tkakel@naver.com>; "BlueZ development"<bluez-devel@lists.sourceforge.net>
Cc: 
Sent: 08-03-20(목) 01:47:11
Subject: Re: [Bluez-devel] I've found a bug in sdp_cstate_get() function.
Hi,
> I've found a bug in sdp_cstate_get() function.
> (bluez-utils/dist/sdpd/request.c)
> -> memcpy(cstate, (sdp_cont_state_t *)pdata, 
> sizeof(sdp_cont_state_t));
> When running this code, "hcid daemon crash" occurred.(memory 
> alignment error)
>
> I think there's a bug with (sdp_cont_state_t *)pdata in 
> sdp_cstate_get() function.
> I fixed this code.
> -> memcpy(cstate, pdata, sizeof(sdp_cont_state_t));
> Now, hcid daemon doesn't die.
>
which version? This should have been fixed by now. Either in the 
latest bluez-utils-3.28 or the CVS.
Regards
Marcel
 
 
tkakel님의 블로그
안녕하세요.

[-- Attachment #2: Type: text/html, Size: 4131 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bluez-devel] RFCOMM sockets
  2008-03-19 16:47 ` Marcel Holtmann
  2008-03-20  4:01   ` 이주영
@ 2008-03-20 11:22   ` Fabrizio Guglielmino
  2008-03-20 12:45     ` Marcel Holtmann
  1 sibling, 1 reply; 6+ messages in thread
From: Fabrizio Guglielmino @ 2008-03-20 11:22 UTC (permalink / raw)
  To: BlueZ development

Hi all,
I have 3 embedded devices with temperature sensor. This devices are 
accessed from a pc with linux reading data with rfcomm socket, isn't 
need to make sdp query for channel because rfcomm channels are 
statically assigned (it's lab equipment).

I need to read the 3 devices almost at same time and I've done a little 
C application using GLib IOChannels and non-blocking socket to read
data from the devices. All works fine but if a device it's off the 
connection to the others it's slow, my impression is it waits timeout 
from the first device.
I can understand why if I have 3 rfcomm connections issued in 
non-blocking way these influences each other.

I'm using BlueZ 3.22 on a debian 4.0 whith kernel version 2.6.22

Thanks

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Bluez-devel] I've found a bug in sdp_cstate_get() function.
  2008-03-20  4:01   ` 이주영
@ 2008-03-20 12:43     ` Marcel Holtmann
  0 siblings, 0 replies; 6+ messages in thread
From: Marcel Holtmann @ 2008-03-20 12:43 UTC (permalink / raw)
  To: 이주영; +Cc: bluez-devel

Hi,

> The version is latest bluez-utils-3.28.
>
>

we fixed it in the CVS. So that should be taken care of when we  
release bluez-utils-3.29.

Regards

Marcel


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Bluez-devel] RFCOMM sockets
  2008-03-20 11:22   ` [Bluez-devel] RFCOMM sockets Fabrizio Guglielmino
@ 2008-03-20 12:45     ` Marcel Holtmann
  0 siblings, 0 replies; 6+ messages in thread
From: Marcel Holtmann @ 2008-03-20 12:45 UTC (permalink / raw)
  To: BlueZ development

Hi Fabrizio,

> I have 3 embedded devices with temperature sensor. This devices are
> accessed from a pc with linux reading data with rfcomm socket, isn't
> need to make sdp query for channel because rfcomm channels are
> statically assigned (it's lab equipment).
>
> I need to read the 3 devices almost at same time and I've done a  
> little
> C application using GLib IOChannels and non-blocking socket to read
> data from the devices. All works fine but if a device it's off the
> connection to the others it's slow, my impression is it waits timeout
> from the first device.
> I can understand why if I have 3 rfcomm connections issued in
> non-blocking way these influences each other.

because if you have to open ACL baseband connections, then it takes  
time. Especially when they fail. The baseband connections can not be  
done in parallel when it is the same host controller. You can use  
hciconfig to change the page timeout.

Regards

Marcel


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2008-03-20 12:45 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-03-19 16:03 [Bluez-devel] I've found a bug in sdp_cstate_get() function 이주영
2008-03-19 16:47 ` Marcel Holtmann
2008-03-20  4:01   ` 이주영
2008-03-20 12:43     ` Marcel Holtmann
2008-03-20 11:22   ` [Bluez-devel] RFCOMM sockets Fabrizio Guglielmino
2008-03-20 12:45     ` Marcel Holtmann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).