From: Guy Harris <guy@alum.mit.edu>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Paul Ionescu <paul@acorp.ro>,
BlueZ Mailing List <bluez-devel@lists.sourceforge.net>,
ethereal-dev@ethereal.com
Subject: Re: [Ethereal-dev] Re: [Bluez-devel] bluetooth ethereal dissector
Date: Thu, 30 Oct 2003 03:54:31 -0800 [thread overview]
Message-ID: <20031030035431.A18203@quadrajet.sonic.net> (raw)
In-Reply-To: <1067513580.18114.20.camel@pegasus>; from marcel@holtmann.org on Thu, Oct 30, 2003 at 12:39:46PM +0100
On Thu, Oct 30, 2003 at 12:39:46PM +0100, Marcel Holtmann wrote:
> Attached is another patch against CVS, which re-introduces the byte
> swapping,
I've checked in a change to replace g_ntohs with GUINT16_FROM_LE and to
replace g_ntohl with GUINT32_FROM_LE.
> I also use the macro _U_ for __attribute((packed))__
The macro _U_ is defined as __attribute__((unused)), not
__attribute((packed))__.
If __attribute((packed))__ is *required* in order to make it work, then
you need to find some *other* way to make it work - conditionally using
__attribute((packed))__ or not depending on whether GCC is being used or
not won't help. For example, define the structure as an array of bytes,
or as a sequence of arrays of bytes, and use the "pletoh" macros to
extract values from them.
However, I see nothing that would *require* __attribute((packed))__.
-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
Does SourceForge.net help you be more productive? Does it
help you create better code? SHARE THE LOVE, and help us help
YOU! Click Here: http://sourceforge.net/donate/
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel
next prev parent reply other threads:[~2003-10-30 11:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-28 22:11 [Bluez-devel] bluetooth ethereal dissector Paul Ionescu
2003-10-29 8:54 ` James Courtier-Dutton
2003-10-29 11:17 ` Marcel Holtmann
2003-10-29 20:16 ` [Ethereal-dev] " Guy Harris
2003-10-29 11:07 ` Marcel Holtmann
2003-10-29 19:26 ` [Ethereal-dev] " Guy Harris
2003-10-30 2:50 ` Marcel Holtmann
2003-10-30 3:13 ` Guy Harris
2003-10-30 11:39 ` Marcel Holtmann
2003-10-30 11:54 ` Guy Harris [this message]
2003-10-30 12:49 ` Marcel Holtmann
2003-10-30 6:22 ` Guy Harris
2003-10-30 12:22 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031030035431.A18203@quadrajet.sonic.net \
--to=guy@alum.mit.edu \
--cc=bluez-devel@lists.sourceforge.net \
--cc=ethereal-dev@ethereal.com \
--cc=marcel@holtmann.org \
--cc=paul@acorp.ro \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox