Re: [Bluez-devel] D-BUS fixes for hcid

[Johan Hedberg <johan.hedberg@nokia.com>]

On Wed, Jun 16, 2004, Marcel Holtmann wrote:
> since I don't know very much about D-Bus, please explain your changes to
> me. Why are they needed?

The first part with the error handling is needed because
dbus_pending_call_get_reply() may return NULL if a timeout occurs (a
reply isn't received in time). Also, if new errors are added in the
future it is probably better to check for the general case here:
dbus_message_get_type().

The second part (dbus_message_set_auto_activation) enables service
activation if the PinAgent service isn't aquired by any process (i.e.
the D-BUS daemon will execute the pin-helper program if needed).

> Don't get your point here, because it works perfect on my Debian Sid.

Do you mean that without these changes, the pin-helper is automatically
launched when a D-BUS message is sent by hcid to the service
org.bluez.PinAgent? I could not get it working without the changes. What
version of D-BUS are you using?

Johan