Re: [Bluez-devel] SBC packer done, kind of

Marcel Holtmann
2004-11-23T06:27:40Z

Hi Henryk,

> Ok, I'm now basically finished with sbc_pack_frame (joint stereo is not
> handled yet). Though I tested it only with mono and two simple test
> signals (one impulse and a sawtooth) because I can't load audio data
> from files. (Marcel?)

these are good news. So I really must code the sbcenc tool now. In what
fields do I have to put the PCM stream and what other things must I set?

> Next thing (after joint stereo) would be some cleanup of sbc.c and
> finally convertion to kernel indentation. I tried the Lindent script but
> don't like what it does to the code, because most of it is nested in
> some kind of for(blk ..) { for(ch ..) { for(sb ..) { ... } } } structure
> and wasting a full 8 columns (out of the precious 80) for each of those
> loops doesn't feel right to me.

Actually that is the main point behind using tabs with the size of 8
spaces. Code that uses too much nested structures become unreadable and
you start thinking of how you can make this easier and make it looking a
little bit nicer. In most cases the answer is inline functions.