From: "Juha Yrjölä" <juha.yrjola@iki.fi>
To: bluez-devel@lists.sourceforge.net
Subject: Re: [Bluez-devel] [PATCH] Fix too-many-keys-pressed error in hidp/core.c
Date: Sun, 23 Jan 2005 13:39:24 +0200 [thread overview]
Message-ID: <20050123113924.GA17069@salvia.homeip.net> (raw)
In-Reply-To: <1106470008.8112.9.camel@pegasus>
Hi Marcel,
On Sun, Jan 23, 2005 at 09:46:48AM +0100, Marcel Holtmann wrote:
> I think we should add a patch for this, but I don't like the way you did
> it. Checking for the end value of a for-loop is not a good programming
> practice. Using memcmp() here should be a lot better and cleaner.
It depends on how you think about the problem. If you see the data as just
an array of bytes, memcmp() is the way to go. If you think of it as 6
consecutive key codes, with each one set to 1, for loop is conceptually the
right thing to use.
Cheers,
Juha
-------------------------------------------------------
This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting
Tool for open source databases. Create drag-&-drop reports. Save time
by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc.
Download a FREE copy at http://www.intelliview.com/go/osdn_nl
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel
next prev parent reply other threads:[~2005-01-23 11:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-19 22:44 [Bluez-devel] [PATCH] Fix too-many-keys-pressed error in hidp/core.c Juha Yrjölä
2005-01-20 0:19 ` Marcel Holtmann
2005-01-20 0:34 ` Juha Yrjölä
2005-01-20 1:01 ` Marcel Holtmann
2005-01-20 9:03 ` Juha Yrjölä
2005-01-23 8:46 ` Marcel Holtmann
2005-01-23 11:39 ` Juha Yrjölä [this message]
2005-01-23 12:01 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050123113924.GA17069@salvia.homeip.net \
--to=juha.yrjola@iki.fi \
--cc=bluez-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox