From: "David S. Miller" <davem@davemloft.net>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: nish.aravamudan@gmail.com, nacc@us.ibm.com,
kernel-janitors@lists.osdl.org,
bluez-devel@lists.sourceforge.net, maxk@qualcomm.com
Subject: Re: [UPDATE PATCH 18/39] net/core: use wait_event_timeout()
Date: Tue, 25 Jan 2005 21:56:39 -0800 [thread overview]
Message-ID: <20050125215639.15de5436.davem@davemloft.net> (raw)
In-Reply-To: <1106472068.10567.5.camel@pegasus>
On Sun, 23 Jan 2005 10:21:08 +0100
Marcel Holtmann <marcel@holtmann.org> wrote:
> we are using the wait queue from struct sock and sk_sleep is already a
> pointer. Converting from and to a pointer and later to the struct again
> to only match an API looks wrong to me and thus this API is wrong, but
> this is only my thought.
>
> Dave, any comments from you about this?
Not really. I think the API is ok, it's a tradeoff between one set
of call types putting in a deref compared to the other. And as the
patch author stated, the bluetooth side is definitely in the
minority.
To be honest, I think the decision is arbitrary.
prev parent reply other threads:[~2005-01-26 5:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20050120235123.GG2600@us.ibm.com>
2005-01-21 0:32 ` [Bluez-devel] Re: [PATCH 18/39] net/core: use wait_event_timeout() Marcel Holtmann
2005-01-21 19:09 ` [UPDATE PATCH " Nishanth Aravamudan
2005-01-22 17:57 ` [Bluez-devel] " Marcel Holtmann
2005-01-22 18:44 ` [KJ] " Nish Aravamudan
2005-01-23 9:21 ` [Bluez-devel] " Marcel Holtmann
2005-01-26 5:56 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050125215639.15de5436.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bluez-devel@lists.sourceforge.net \
--cc=kernel-janitors@lists.osdl.org \
--cc=marcel@holtmann.org \
--cc=maxk@qualcomm.com \
--cc=nacc@us.ibm.com \
--cc=nish.aravamudan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox