From: Nishanth Aravamudan <nacc@us.ibm.com>
To: marcel@holtmann.org, maxk@qualcomm.com
Cc: bluez-devel@lists.sourceforge.net, kernel-janitors@lists.osdl.org
Subject: [PATCH] bluetooth/bluecard_cs: remove interruptible_sleep_on_timeout() usage
Date: Mon, 28 Feb 2005 10:58:34 -0800 [thread overview]
Message-ID: <20050228185834.GB3261@us.ibm.com> (raw)
Hello,
This patch should not have the oops problems that the original did.
Marcel, please test when you get the chance.
Thanks,
Nish
Description: Remove deprecated interruptible_sleep_on_timeout() function calls
and replace with direct wait-queue usage. Some naming conflicts occurred, which
I tried to resolve appropriately. Patch is compile-tested.
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
--- 2.6.11-rc5-v/drivers/bluetooth/bluecard_cs.c 2005-02-28 10:26:08.000000000 -0800
+++ 2.6.11-rc5/drivers/bluetooth/bluecard_cs.c 2005-02-28 10:56:32.000000000 -0800
@@ -35,6 +35,7 @@
#include <linux/ioport.h>
#include <linux/spinlock.h>
#include <linux/moduleparam.h>
+#include <linux/wait.h>
#include <linux/skbuff.h>
#include <asm/io.h>
@@ -289,8 +290,9 @@ static void bluecard_write_wakeup(blueca
clear_bit(ready_bit, &(info->tx_state));
if (skb->pkt_type & 0x80) {
+ DECLARE_WAIT_QUEUE_HEAD(wq);
+ DEFINE_WAIT(wait);
- wait_queue_head_t wait;
unsigned char baud_reg;
switch (skb->pkt_type) {
@@ -311,8 +313,9 @@ static void bluecard_write_wakeup(blueca
}
/* Wait until the command reaches the baseband */
- init_waitqueue_head(&wait);
- interruptible_sleep_on_timeout(&wait, HZ / 10);
+ prepare_to_wait(&wq, &wait, TASK_INTERRUPTIBLE);
+ schedule_timeout(HZ/10);
+ finish_wait(&wq, &wait);
/* Set baud on baseband */
info->ctrl_reg &= ~0x03;
@@ -324,8 +327,9 @@ static void bluecard_write_wakeup(blueca
outb(info->ctrl_reg, iobase + REG_CONTROL);
/* Wait before the next HCI packet can be send */
- interruptible_sleep_on_timeout(&wait, HZ);
-
+ prepare_to_wait(&wq, &wait, TASK_INTERRUPTIBLE);
+ schedule_timeout(HZ);
+ finish_wait(&wq, &wait);
}
if (len == skb->len) {
next reply other threads:[~2005-02-28 18:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-28 18:58 Nishanth Aravamudan [this message]
2005-03-05 12:22 ` [Bluez-devel] Re: [PATCH] bluetooth/bluecard_cs: remove interruptible_sleep_on_timeout() usage Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050228185834.GB3261@us.ibm.com \
--to=nacc@us.ibm.com \
--cc=bluez-devel@lists.sourceforge.net \
--cc=kernel-janitors@lists.osdl.org \
--cc=marcel@holtmann.org \
--cc=maxk@qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox