From: Greg KH <greg@kroah.com>
To: Oliver Neukum <oliver@neukum.org>
Cc: Johannes Berg <johannes@sipsolutions.net>,
linux-usb-devel@lists.sourceforge.net, marcel@holtmann.org,
maxk@qualcomm.com, linux-kernel@vger.kernel.org,
bluez-devel@lists.sourceforge.net
Subject: Re: [linux-usb-devel] Re: [PATCH] hci_usb: implement suspend/resume
Date: Wed, 18 Jan 2006 12:46:00 -0800 [thread overview]
Message-ID: <20060118204600.GB18902@kroah.com> (raw)
In-Reply-To: <200601181634.08869.oliver@neukum.org>
On Wed, Jan 18, 2006 at 04:34:08PM +0100, Oliver Neukum wrote:
> Am Mittwoch, 18. Januar 2006 15:13 schrieb Johannes Berg:
> > On Wed, 2006-01-18 at 14:25 +0100, Oliver Neukum wrote:
> >
> > > This patch is wrong. usb_kill_urb() will sleep. You must not use it under
> > > a spinlock.
> >
> > Whoops. Good catch. I'll have to analyse the logic with the lists being
> > used here (and probably add a temporary list). Will try to get a new
> > patch until tomorrow.
> >
> > [side note: how about adding might_sleep() to usb_kill_urb? Then I'd at
> > least have noticed this right away]
>
> Good idea.
Done.
thanks,
greg k-h
prev parent reply other threads:[~2006-01-18 20:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1137540084.4543.15.camel@localhost>
2006-01-18 13:13 ` [Bluez-devel] Re: [PATCH] hci_usb: implement suspend/resume Marcel Holtmann
[not found] ` <1137602323.4543.29.camel@localhost>
2006-02-09 1:08 ` John McCabe-Dansted
[not found] ` <1142934130.3964.14.camel@localhost>
2006-03-21 9:52 ` Marcel Holtmann
[not found] ` <200601181425.35524.oliver@neukum.org>
[not found] ` <1137593621.4543.22.camel@localhost>
[not found] ` <200601181634.08869.oliver@neukum.org>
2006-01-18 20:46 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060118204600.GB18902@kroah.com \
--to=greg@kroah.com \
--cc=bluez-devel@lists.sourceforge.net \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=marcel@holtmann.org \
--cc=maxk@qualcomm.com \
--cc=oliver@neukum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).