[Bluez-devel] bug in hci_uart_tx_wakeup() causes panic when UART removed

[Bluez-devel] bug in hci_uart_tx_wakeup() causes panic when UART removed

[Karol Kozimor]

Hi,
Under specific circumstances, hci_uart_tx_wakeup() seems to call
tty->driver->write() without checking if the tty is alive, which
effectively causes a nasty panic in uart_write(). From what I've read so
far it seems that hci_ldisc.c is to blame, so I'm reporting it here.

This is related to:
http://sourceforge.net/mailarchive/message.php?msg_id=14724441

See also:
http://bugme.osdl.org/show_bug.cgi?id=6131
http://bugzilla.kernel.org/show_bug.cgi?id=5958

Best regards,

-- 
Karol 'sziwan' Kozimor
sziwan@hell.org.pl


-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Re: [Bluez-devel] bug in hci_uart_tx_wakeup() causes panic when UART removed

[Marcel Holtmann]

Hi Karol,

> Under specific circumstances, hci_uart_tx_wakeup() seems to call
> tty->driver->write() without checking if the tty is alive, which
> effectively causes a nasty panic in uart_write(). From what I've read so
> far it seems that hci_ldisc.c is to blame, so I'm reporting it here.

and I haven't seen a patch for it or any advice on how to fix this. At
the moment I have no time to fully track this down.

Regards

Marcel




-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

[Bluez-devel] Re: bug in hci_uart_tx_wakeup() causes panic when UART removed

[Russell King]

On Sun, Feb 26, 2006 at 03:59:35PM +0100, Karol Kozimor wrote:
> Hi,
> Under specific circumstances, hci_uart_tx_wakeup() seems to call
> tty->driver->write() without checking if the tty is alive, which
> effectively causes a nasty panic in uart_write(). From what I've read so
> far it seems that hci_ldisc.c is to blame, so I'm reporting it here.
> 
> This is related to:
> http://sourceforge.net/mailarchive/message.php?msg_id=14724441
> 
> See also:
> http://bugme.osdl.org/show_bug.cgi?id=6131
> http://bugzilla.kernel.org/show_bug.cgi?id=5958

As a priority, I especially recommend bluetooth developers read:

http://bugzilla.kernel.org/show_bug.cgi?id=5958#c2

where bug 6131 was predicted.

-- 
Russell King


-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Re: [Bluez-devel] Re: bug in hci_uart_tx_wakeup() causes panic when UART removed

[Marcel Holtmann]

Hi Russell,

> > Under specific circumstances, hci_uart_tx_wakeup() seems to call
> > tty->driver->write() without checking if the tty is alive, which
> > effectively causes a nasty panic in uart_write(). From what I've read so
> > far it seems that hci_ldisc.c is to blame, so I'm reporting it here.
> > 
> > This is related to:
> > http://sourceforge.net/mailarchive/message.php?msg_id=14724441
> > 
> > See also:
> > http://bugme.osdl.org/show_bug.cgi?id=6131
> > http://bugzilla.kernel.org/show_bug.cgi?id=5958
> 
> As a priority, I especially recommend bluetooth developers read:
> 
> http://bugzilla.kernel.org/show_bug.cgi?id=5958#c2
> 
> where bug 6131 was predicted.

I saw that we didn't implement the hangup callback. Will it be
sufficient to use it to shutdown our HCI interface?

Regards

Marcel




-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel