public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: BlueZ development <bluez-devel@lists.sourceforge.net>
Subject: Re: [Bluez-devel] system freeze in 2.6.17-mh5
Date: Wed, 2 Aug 2006 23:00:08 +0200	[thread overview]
Message-ID: <20060802210008.GA3043@lst.de> (raw)
In-Reply-To: <1154525837.3905.49.camel@aeonflux.holtmann.net>

On Wed, Aug 02, 2006 at 03:37:17PM +0200, Marcel Holtmann wrote:
> > BUG: scheduling while atomic: swapper/0x00000100/0
> >  <c02ecbd2> wait_for_completion+0x82/0xb6  <c0115504>
> > default_wake_function+0x0/0x12 <c0115504>
> > default_wake_function+0x0/0x12  <c0113c8e> wake_up_process+0xd/0xf
> > <c02e8b6f> hidp_idle_timeout+0x0/0x10  <c01297e2>
> > kthread_stop_sem+0x74/0x93 <c012976b> kthread_stop+0xb/0xe  <c01213bb>

> this looks like a problem with the kthread API. We converted BNEP, CMTP
> and HIDP to it with 2.6.17-mh3. So a 2.6.17-mh2 kernel should work
> without any problems.
> 
> Christoph, any ideas. Did you see a similar problem before.

kthread_stop can sleep, hidp_idle_timeout is called from a timer, thus
running in softirq context.

Why does hidp try to tear down the thread on this timeout anyway?  It
seems much more logical to me to only do it in hidp_del_connection so
that it's symmetric to starting the thread in hidp_add_connection.

  parent reply	other threads:[~2006-08-02 21:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-02 10:07 [Bluez-devel] system freeze in 2.6.17-mh5 Stefan Maintz
2006-08-02 13:37 ` Marcel Holtmann
2006-08-02 17:16   ` Stefan Maintz
2006-08-02 21:00   ` Christoph Hellwig [this message]
2006-08-03 10:39     ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060802210008.GA3043@lst.de \
    --to=hch@lst.de \
    --cc=bluez-devel@lists.sourceforge.net \
    --cc=marcel@holtmann.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox