Re: [Bluez-devel] [PATCH] implement RFCOMM Connect and Disconnect methods

Matthew Garrett
2006-08-19T23:53:30Z

On Sun, Aug 20, 2006 at 03:39:33AM +0200, Marcel Holtmann wrote:

> thanks for the patch, but what is the problem with sticking to Connect
> and CancelConnect and use their service string to identify UUID, handle
> or service name bases connections.

I'm not quite clear on what you mean here. The service string seems
unacceptable because it requires bluez to have a table of every possible
service and UUID in existence. Or are we talking about different things?
Right now, the API gives us the following things that potentially
identify an object:

1) The identifiers returned by GetIdentifiers (currently an arbitrary
but unique integer, despite dbus-api.txt claiming it returns strings)
2) The UUID
3) The service handle
4) The ascii service string

My implementation provides connect methods for (2), (3) and (4). You
didn't seem too happy about my patch providing support for (1), so I've
dropped it :) Or do you just mean that there should be a single method
and it should work out which piece of information has been passed by the
app? In that case, I didn't implement it that way because determining
the type was a bit of a pain and struck me as potentially fragile.