[Bluez-devel] rfcomm_sock_sendmsg with len==0 (in Linux 2.6.18)

[Tuomas Suutari <thsuut@utu.fi>]

Hello.

I've made a buffer for socket connections to use with C++ iostreams. 
It's quite simple; just uses send and recv to fill and empty the buffer 
when needed.

It worked fine for a while, but yesterday some strange errors occured 
with it. After few hours of debugging I found that code responsible was 
using syscall send() to Bluetooth socket with buffer length set to 0. 
Problem was that I assumed it to return either -1 on error or 0 when 
success, but instead it returned positive values sometimes. 

Ok, it was stupid calling send() with len==0 anyway, but still (at least 
according to manual) send shouldn't return anything positive then. So I 
traced what kernel code is responsible and found it's 
rfcomm_sock_sendmsg() in net/bluetooth/rfcomm/sock.c. It returns 
uninitialized variable err, if called with len==0.

Simple fix is to initialize err to 0.

-- 
Tuomas Suutari | +358 50 3806983 | thsuut@utu.fi

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel