Linux bluetooth development
 help / color / mirror / Atom feed
From: Denis KENZIOR <denis.kenzior@trolltech.com>
To: Bluez-devel@lists.sourceforge.net
Subject: [Bluez-devel] [PATCH] Minor issues with sdp-xml
Date: Tue, 6 Feb 2007 15:13:32 +1000	[thread overview]
Message-ID: <200702061513.32173.denis.kenzior@trolltech.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 69 bytes --]

Marcel,

This patch fixes up a couple of minor bugs I found.

-Denis

[-- Attachment #2: sdp-xml.patch --]
[-- Type: text/x-diff, Size: 929 bytes --]

Index: sdp-xml.c
===================================================================
RCS file: /cvsroot/bluez/utils/common/sdp-xml.c,v
retrieving revision 1.7
diff -u -r1.7 sdp-xml.c
--- sdp-xml.c	20 Jan 2007 21:28:02 -0000	1.7
+++ sdp-xml.c	6 Feb 2007 05:12:31 -0000
@@ -265,7 +265,7 @@
 		if (hex) {
 			appender(data, "encoding=\"hex\" ");
 			strBuf = (char *) malloc(sizeof(char)
-						 * (value->unitSize * 2 + 1));
+						 * ((value->unitSize-1) * 2 + 1));
 
 			/* Unit Size seems to include the size for dtd
 			   It is thus off by 1
@@ -276,7 +276,7 @@
 					"%02x",
 					(unsigned char) value->val.str[i]);
 
-			strBuf[value->unitSize * 2] = '\0';
+			strBuf[(value->unitSize-1) * 2] = '\0';
 		}
 		else {
 			int j;
@@ -603,7 +603,7 @@
 			buf[0] = data[i];
 			buf[1] = data[i + 1];
 
-			val.data[i] = strtoul(buf, 0, 16);
+			val.data[i >> 1] = strtoul(buf, 0, 16);
 		}
 
 		ret = sdp_data_alloc(dtd, &val);

[-- Attachment #3: Type: text/plain, Size: 374 bytes --]

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

[-- Attachment #4: Type: text/plain, Size: 164 bytes --]

_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

             reply	other threads:[~2007-02-06  5:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-06  5:13 Denis KENZIOR [this message]
2007-02-06 17:16 ` [Bluez-devel] [PATCH] Minor issues with sdp-xml Stefan Seyfried
2007-02-12 19:49 ` Marcel Holtmann
2007-02-13 11:33   ` [Bluez-devel] Linux Distribution for Bluez enigma enu
2007-02-13 13:03     ` Marcel Holtmann
2007-02-14 15:13       ` enigma enu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200702061513.32173.denis.kenzior@trolltech.com \
    --to=denis.kenzior@trolltech.com \
    --cc=Bluez-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox