public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
From: Andreas Gaufer <Andreas.Gaufer@bluecellnetworks.com>
To: Bluez Devel <bluez-devel@lists.sourceforge.net>
Subject: [Bluez-devel] [PATCH] Fix broken EVT_REMOTE_NAME_REQ_COMPLETE
Date: Thu, 25 Oct 2007 12:06:53 +0200	[thread overview]
Message-ID: <20071025120653.5a89aebe@localhost.localdomain> (raw)

[-- Attachment #1: Type: text/plain, Size: 547 bytes --]

Hi Marcel,

I'm sending this bluez-libs patch for the third time now and i wonder why
you do not include it. If there is anything wrong with it please let me know
so I can learn.

Please look at 

http://article.gmane.org/gmane.linux.bluez.devel/13859
http://thread.gmane.org/gmane.linux.bluez.devel/12491

We did extensive testing and rolled that patch into production
environment already and there is another independent user (Matthias
Becker) who confirmed its usefulness.

Hoping to hear from You

Andreas Gaufer

I fully agree with RFC 1855


[-- Attachment #2: bluez-libs-3.21-EVT_REMOTE_NAME_REQ_COMPLETE.patch --]
[-- Type: application/octet-stream, Size: 799 bytes --]

diff -ur bluez-libs-3.21-orig/src/hci.c bluez-libs-3.21/src/hci.c
--- bluez-libs-3.21-orig/src/hci.c	2007-10-05 09:15:52.000000000 +0200
+++ bluez-libs-3.21/src/hci.c	2007-10-25 11:57:47.729655584 +0200
@@ -1010,6 +1010,8 @@
 	while (try--) {
 		evt_cmd_complete *cc;
 		evt_cmd_status   *cs;
+		evt_remote_name_req_complete *rn;
+		remote_name_req_cp *cp;
 
 		if (to) {
 			struct pollfd p;
@@ -1074,6 +1076,21 @@
 			memcpy(r->rparam, ptr, r->rlen);
 			goto done;
 
+		case EVT_REMOTE_NAME_REQ_COMPLETE:
+
+			if (hdr->evt != r->event)
+				break;
+
+			r->rlen = MIN(len, r->rlen);
+			memcpy(r->rparam, ptr, r->rlen);
+
+			rn = r->rparam;
+			cp = r->cparam;
+
+			if (bacmp(&rn->bdaddr,&cp->bdaddr) == 0)
+				goto done;
+			continue;
+
 		default:
 			if (hdr->evt != r->event)
 				break;

[-- Attachment #3: Type: text/plain, Size: 314 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/

[-- Attachment #4: Type: text/plain, Size: 164 bytes --]

_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

             reply	other threads:[~2007-10-25 10:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-25 10:06 Andreas Gaufer [this message]
2007-10-25 23:04 ` [Bluez-devel] [PATCH] Fix broken EVT_REMOTE_NAME_REQ_COMPLETE Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071025120653.5a89aebe@localhost.localdomain \
    --to=andreas.gaufer@bluecellnetworks.com \
    --cc=bluez-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox