From: Pavel Semerad <semerad@sisal.mff.cuni.cz>
To: bluez-devel@lists.sourceforge.net
Subject: [Bluez-devel] patch removing one extra memset
Date: Tue, 8 Jan 2008 00:09:10 +0100 [thread overview]
Message-ID: <20080107230910.GA5883@ps.ms.mff.cuni.cz> (raw)
Helo,
I have found one mistake in audio/ctl_bluetooth.c . When initializing
this plugin, 'data' is allocated and memset-ed to 0. Then socket is
created and assigned to 'data'. And then there is another memset, which
sets this socket back to zero.
Patch removing this extra memset is attached:
--- ./audio/ctl_bluetooth.c.ps 2007-12-08 20:04:39.000000000 +0100
+++ ./audio/ctl_bluetooth.c 2008-01-07 23:41:23.000000000 +0100
@ -327,8 +327,6 @@ SND_CTL_PLUGIN_DEFINE_FUNC(bluetooth)
if (err < 0)
goto error;
- memset(data, 0, sizeof(*data));
-
data->ext.version = SND_CTL_EXT_VERSION;
data->ext.card_idx = -1;
Pavel Semerad
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel
next reply other threads:[~2008-01-07 23:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-07 23:09 Pavel Semerad [this message]
2008-01-07 23:47 ` [Bluez-devel] patch removing one extra memset Brad Midgley
2008-01-08 15:23 ` [Bluez-devel] [PATCH] HFP method "SetupCall" + audio-api.txt update Alok
2008-01-08 18:28 ` Marcel Holtmann
2008-01-09 3:06 ` Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080107230910.GA5883@ps.ms.mff.cuni.cz \
--to=semerad@sisal.mff.cuni.cz \
--cc=bluez-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox