From: David Miller <davem@davemloft.net>
To: hidave.darkstar@gmail.com
Cc: marcel@holtmann.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, bluez-devel@lists.sourceforge.net
Subject: Re: [PATCH] bluetooth : rfcomm tty BUG_ON() code fix
Date: Thu, 10 Jan 2008 22:23:20 -0800 (PST) [thread overview]
Message-ID: <20080110.222320.247508342.davem@davemloft.net> (raw)
In-Reply-To: <20080107054122.GA4502@darkstar.te-china.tietoenator.com>
From: Dave Young <hidave.darkstar@gmail.com>
Date: Mon, 7 Jan 2008 13:41:22 +0800
> 1) In tty.c the BUG_ON at line 115 will never be called, because the the before list_del_init in this same function.
> 115 BUG_ON(!list_empty(&dev->list));
> So move the list_del_init to rfcomm_dev_del
>
> 2) The rfcomm_dev_del could be called from diffrent path (rfcomm_tty_hangup/rfcomm_dev_state_change/rfcomm_release_dev),
> So add another BUG_ON when the rfcomm_dev_del is called more than one time.
>
> Signed-off-by: Dave Young <hidave.darkstar@gmail.com>
Applied, thanks Dave.
prev parent reply other threads:[~2008-01-11 6:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-07 5:41 [PATCH] bluetooth : rfcomm tty BUG_ON() code fix Dave Young
2008-01-11 6:23 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080110.222320.247508342.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bluez-devel@lists.sourceforge.net \
--cc=hidave.darkstar@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox