From: Siarhei Siamashka <siarhei.siamashka@nokia.com>
To: "ext Christian Hoene" <hoene@uni-tuebingen.de>
Cc: "'Marcel Holtmann'" <marcel@holtmann.org>,
linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] sbc: bitstream packing optimization for encoder.
Date: Wed, 17 Dec 2008 16:16:52 +0200 [thread overview]
Message-ID: <200812171616.52348.siarhei.siamashka@nokia.com> (raw)
In-Reply-To: <00c801c95c6d$9953dad0$cbfb9070$@de>
On Friday 12 December 2008 17:23:33 ext Christian Hoene wrote:
> Hi all,
>
> next week I will discuss the bug fixing of SBC with Jaska Uimonen, who is
> ill this week.
>
> The sound quality of the fix point implementation still remains below of
> the quality of the floating point version.
Has the sound quality improved with the latest patches?
By the way, which floating point version do you have in mind? Is it btsco,
which is referenced from this wiki page: http://wiki.bluez.org/wiki/SBC ?
I tried to have a look at btsco, but it seems to be much worse quality wise
than the fixed point version with an updated filtering function. I tried to
encode some audio sample, decode it back and compare result with the
original file in both cases.
Also I compared 32-bit fixed point vs. 16-bit fixed point, and looks like
16-bit fixed point version has a sufficient precision. Anyway, the values,
received from the filter, are quantized later and much more information
about lower order bits is usually lost at this stage.
--
Best regards,
Siarhei Siamashka
next prev parent reply other threads:[~2008-12-17 14:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-11 20:27 [PATCH] sbc: bitstream packing optimization for encoder Siarhei Siamashka
2008-12-12 1:39 ` Marcel Holtmann
2008-12-12 9:37 ` Siarhei Siamashka
2008-12-12 11:04 ` Marcel Holtmann
2008-12-12 15:23 ` Christian Hoene
2008-12-12 15:30 ` Marcel Holtmann
2008-12-12 15:49 ` Christian Hoene
2008-12-12 15:56 ` Marcel Holtmann
2008-12-12 16:01 ` Siarhei Siamashka
2008-12-17 14:16 ` Siarhei Siamashka [this message]
2008-12-12 16:07 ` Siarhei Siamashka
2008-12-16 21:46 ` Siarhei Siamashka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200812171616.52348.siarhei.siamashka@nokia.com \
--to=siarhei.siamashka@nokia.com \
--cc=hoene@uni-tuebingen.de \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox