From: Derek Chan <dwc+lkml@OCF.Berkeley.EDU>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: maxk@qualcomm.com, linux-bluetooth@vger.kernel.org
Subject: Re: another "blacklist" device for hci_usb
Date: Tue, 3 Mar 2009 23:59:02 -0800 [thread overview]
Message-ID: <20090304075902.GB3004@OCF.Berkeley.EDU> (raw)
In-Reply-To: <1235857191.6074.39.camel@localhost.localdomain>
[-- Attachment #1: Type: text/plain, Size: 2154 bytes --]
On Sat, Feb 28, 2009 at 10:39:51PM +0100, Marcel Holtmann wrote:
>> I've got a USB bluetooth adapter that needed some of those handy module
>> params to get SCO working.
>>
>> Bus 001 Device 004: ID 0a5c:2121 Broadcom Corp. BCM2210 Bluetooth
> send "hciconfig -a" before and after your patch. You have to prove to me
> that you really need this patch.
Before: (2.6.26-1-686, no options for hci_usb)
hci0: Type: USB
BD Address: 00:50:B6:80:76:1A ACL MTU: 1017:8 SCO MTU: 64:0
UP RUNNING PSCAN
RX bytes:939 acl:0 sco:0 events:23 errors:0
TX bytes:342 acl:0 sco:0 commands:23 errors:0
Features: 0xff 0xff 0x8d 0xfe 0x9b 0xf9 0x00 0x80
Packet type: DM1 DM3 DM5 DH1 DH3 DH5 HV1 HV2 HV3
Link policy: RSWITCH HOLD SNIFF PARK
Link mode: SLAVE ACCEPT
Name: 'server-0'
Class: 0x080100
Service Classes: Capturing
Device Class: Computer, Uncategorized
HCI Ver: 2.0 (0x3) HCI Rev: 0x4118 LMP Ver: 2.0 (0x3) LMP Subver: 0x430e
Manufacturer: Broadcom Corporation (15)
After: (2.6.26-1-686, options hci_usb reset=1 force_scofix=1)
hci0: Type: USB
BD Address: 00:50:B6:80:76:1A ACL MTU: 1017:8 SCO MTU: 64:8
UP RUNNING PSCAN
RX bytes:1511 acl:0 sco:0 events:31 errors:0
TX bytes:366 acl:0 sco:0 commands:31 errors:0
Features: 0xff 0xff 0x8d 0xfe 0x9b 0xf9 0x00 0x80
Packet type: DM1 DM3 DM5 DH1 DH3 DH5 HV1 HV2 HV3
Link policy: RSWITCH HOLD SNIFF PARK
Link mode: SLAVE ACCEPT
Name: 'server-0'
Class: 0x080100
Service Classes: Capturing
Device Class: Computer, Uncategorized
HCI Ver: 2.0 (0x3) HCI Rev: 0x4118 LMP Ver: 2.0 (0x3) LMP Subver: 0x430e
Manufacturer: Broadcom Corporation (15)
> Also please post a patch against btusb.c since hci_usb.c has been
> removed.
I didn't actually patch hci_usb. Since the options were there, it was
easier to use them. As requested, I've gone back through gitweb to pull
this file to patch. See attached.
- Derek
--
Be the change you want to see in the world
-- Mahatma Gandhi
[-- Attachment #2: btusb.patch --]
[-- Type: text/plain, Size: 551 bytes --]
--- btusb.c.orig 2009-03-03 23:48:07.000000000 -0800
+++ btusb.c 2009-03-03 23:49:09.000000000 -0800
@@ -101,6 +101,9 @@
{ USB_DEVICE(0x0a5c, 0x2039), .driver_info = BTUSB_RESET | BTUSB_WRONG_SCO_MTU },
{ USB_DEVICE(0x0a5c, 0x2101), .driver_info = BTUSB_RESET | BTUSB_WRONG_SCO_MTU },
+ /* Broadcom BCM2210 */
+ { USB_DEVICE(0x0a5c, 0x2121), .driver_info = BTUSB_RESET | BTUSB_WRONG_SCO_MTU },
+
/* Broadcom BCM2046 */
{ USB_DEVICE(0x0a5c, 0x2146), .driver_info = BTUSB_RESET },
{ USB_DEVICE(0x0a5c, 0x2151), .driver_info = BTUSB_RESET },
next prev parent reply other threads:[~2009-03-04 7:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-26 9:17 another "blacklist" device for hci_usb Derek Chan
2009-02-28 21:39 ` Marcel Holtmann
2009-03-04 7:59 ` Derek Chan [this message]
2009-03-04 21:00 ` Marcel Holtmann
2009-03-04 23:46 ` Derek Chan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090304075902.GB3004@OCF.Berkeley.EDU \
--to=dwc+lkml@ocf.berkeley.edu \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=maxk@qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox