From: Johan Hedberg <johan.hedberg@gmail.com>
To: Nick Pelly <npelly@google.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [RFC] [PATCH] Do no process a stream as connected if AVDTP set configuration failed
Date: Mon, 9 Mar 2009 17:00:19 -0300 [thread overview]
Message-ID: <20090309200019.GA6610@jh-x301> (raw)
In-Reply-To: <35c90d960903061659x433122ddrf6fb38ec02a50d60@mail.gmail.com>
Hi Nick,
On Fri, Mar 06, 2009, Nick Pelly wrote:
> Right now, if set configuration fails then the
> sink.c:stream_setup_complete seems to consider the stream connected.
> So the DBus AudioSink.Connect() call returns without error. But the
> stream is not actually ready.
>
> I have a feeling we may want to do some more cleanup, but this patch
> does the trick for us.
>
> It is easy to reproduce the problem with the HTC BH S100. If you
> quickly disconnect and then reconnect it will return AVDTP set
> configuration failed (presumably because it hasn't closed the SEP on
> its end yet), but Dbus does not return an error for Connect.
Thanks for the patch. I pushed a slightly modified fix since the
callback should always get NULL for the stream if there was an error:
http://git.kernel.org/?p=bluetooth/bluez.git;a=commitdiff;h=8f619dd6228f1cfa750e562d4e2ea89396e8b4fd
Johan
prev parent reply other threads:[~2009-03-09 20:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-07 0:59 [RFC] [PATCH] Do no process a stream as connected if AVDTP set configuration failed Nick Pelly
2009-03-09 20:00 ` Johan Hedberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090309200019.GA6610@jh-x301 \
--to=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=npelly@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox