From: Johan Hedberg <johan.hedberg@gmail.com>
To: Nick Pelly <npelly@google.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Null pointer check on cb in finalize_resume()
Date: Fri, 27 Mar 2009 11:49:21 +0200 [thread overview]
Message-ID: <20090327094921.GA2711@jh-x301> (raw)
In-Reply-To: <35c90d960903261650s7d4031a4v764682e2d7ea953c@mail.gmail.com>
Hi Nick,
Thanks for the patches. All of them, except for this one, seemed fine.
On Thu, Mar 26, 2009, Nick Pelly wrote:
> From: Nick Pelly <npelly@google.com>
> Date: Thu, 26 Mar 2009 15:22:32 -0700
> Subject: [PATCH] Null pointer check on cb in finalize_resume().
>
> Fix a null pointer crash that occured when resuming A2DP streaming after
> making an outgoing call.
This looks like it's covering up for another bug where we've added a NULL
element into the list. I went through the current code and there are two places
where elements are added to the list. Both of these places use g_new0 which
will never return NULL (the default GLib behavior or to call abort() in the
case of an allocation failure) so most likely this added NULL check is
unnecessary with the current code base (but of course doesn't really hurt
either).
Johan
prev parent reply other threads:[~2009-03-27 9:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-26 23:50 [PATCH] Null pointer check on cb in finalize_resume() Nick Pelly
2009-03-27 9:49 ` Johan Hedberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090327094921.GA2711@jh-x301 \
--to=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=npelly@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox