From: Johan Hedberg <johan.hedberg@gmail.com>
To: alokbarsode@gmail.com
Cc: linux-bluetooth@vger.kernel.org, marcel@holtmann.com,
Alok Barsode <alok.barsode@azingo.com>
Subject: Re: [PATCH 3/3] Adding stop() functionality to hciops plugin.
Date: Mon, 4 May 2009 18:30:50 +0300 [thread overview]
Message-ID: <20090504153050.GC28443@jh-x301> (raw)
In-Reply-To: <1241449694-17135-3-git-send-email-alok.barsode@azingo.com>
Hi Alok,
On Mon, May 04, 2009, alokbarsode@gmail.com wrote:
> From: Alok Barsode <alok.barsode@azingo.com>
>
> ---
> plugins/hciops.c | 24 ++++++++++++++++++++++++
> src/adapter.c | 25 ++++++++++++++-----------
> src/adapter.h | 1 +
> 3 files changed, 39 insertions(+), 11 deletions(-)
This patch is fine assuming that we don't want to exit when
adapter_ops_setup fails. Though now it's apparent that the code would get
simpler if we would exit() in that case since then we don't need to have
any "if (adapter_ops)" checks later in the code.
Johan
next prev parent reply other threads:[~2009-05-04 15:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-04 15:08 [PATCH 1/3] Do not exit if adapter_ops setup fails alokbarsode
2009-05-04 15:08 ` [PATCH 2/3] Code cleanup in adapter.c alokbarsode
2009-05-04 15:08 ` [PATCH 3/3] Adding stop() functionality to hciops plugin alokbarsode
2009-05-04 15:30 ` Johan Hedberg [this message]
2009-05-04 15:27 ` [PATCH 2/3] Code cleanup in adapter.c Johan Hedberg
2009-05-04 15:25 ` [PATCH 1/3] Do not exit if adapter_ops setup fails Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090504153050.GC28443@jh-x301 \
--to=johan.hedberg@gmail.com \
--cc=alok.barsode@azingo.com \
--cc=alokbarsode@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox