From: Denis Kenzior <denis.kenzior@intel.com>
To: "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Subject: [PATCH] Fix introspection issue in gdbus
Date: Mon, 11 May 2009 13:45:49 -0500 [thread overview]
Message-ID: <200905111345.50534.denis.kenzior@intel.com> (raw)
In-Reply-To: <79DD16001F75DB4EB7DE37CDD687BB2001B723C4@dalamsexb02.AMERICAS.ROOT.PRI>
[-- Attachment #1: Type: text/plain, Size: 306 bytes --]
Hi Marcel,
Attached is a patch to fix a small issue with introspection when using gdbus
library. Basically the introspection data for '/' can never be invalidated,
which leads to funny results when objects are added & removed from '/'
hierarchy.
Attached patch should fix the issue.
Regards,
-Denis
[-- Attachment #2: 0001-Make-the-parent-path-invalidateable.patch --]
[-- Type: text/x-patch, Size: 752 bytes --]
From 3cd7a2c3483ceac8950c32d0c96786b15e05946f Mon Sep 17 00:00:00 2001
From: Denis Kenzior <denis.kenzior@intel.com>
Date: Wed, 1 Apr 2009 16:56:53 -0500
Subject: [PATCH] Make the parent path invalidateable
---
gdbus/object.c | 6 +++++-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/gdbus/object.c b/gdbus/object.c
index 2823054..3186921 100644
--- a/gdbus/object.c
+++ b/gdbus/object.c
@@ -307,7 +307,11 @@ static void invalidate_parent_data(DBusConnection *conn, const char *child_path)
if (!slash)
goto done;
- *slash = '\0';
+ if (slash == parent_path && parent_path[1] != '\0')
+ parent_path[1] = '\0';
+ else
+ *slash = '\0';
+
if (!strlen(parent_path))
goto done;
--
1.6.0.6
next prev parent reply other threads:[~2009-05-11 18:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-07 21:01 bluez 4.x questions, SCO stops Brock Denson
2009-05-07 21:25 ` Johan Hedberg
2009-05-07 22:00 ` Brock Denson
2009-05-07 23:59 ` Brock Denson
2009-05-11 18:45 ` Denis Kenzior [this message]
2009-05-11 18:51 ` [PATCH] Fix introspection issue in gdbus Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200905111345.50534.denis.kenzior@intel.com \
--to=denis.kenzior@intel.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox