From: Johan Hedberg <johan.hedberg@gmail.com>
To: alokbarsode@gmail.com
Cc: linux-bluetooth@vger.kernel.org, marcel@holtmann.org,
Alok Barsode <alok.barsode@azingo.com>
Subject: Re: [PATCH 2/7] Adding set_powered method to hciops plugin.
Date: Fri, 15 May 2009 21:22:56 +0300 [thread overview]
Message-ID: <20090515182256.GA18375@jh-x301> (raw)
In-Reply-To: <1242131216-4081-2-git-send-email-alok.barsode@azingo.com>
Hi Alok,
I'm going through your patches now and I found at least one issue:
> + hci_send_cmd(dd, OGF_HOST_CTL, OCF_WRITE_SCAN_ENABLE,
> + 1, SCAN_DISABLED);
This looks wrong. The last parameter should a pointer and not an integer.
Johan
next prev parent reply other threads:[~2009-05-15 18:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-12 12:26 [PATCH 1/7] Using hci_send_cmd instead of hci_send_req to set scan mode alokbarsode
2009-05-12 12:26 ` [PATCH 2/7] Adding set_powered method to hciops plugin alokbarsode
2009-05-12 12:26 ` [PATCH 3/7] Adding set_connectable " alokbarsode
2009-05-12 12:26 ` [PATCH 4/7] Adding set_discoverable method to hciops alokbarsode
2009-05-12 12:26 ` [PATCH 5/7] Modifying load_connections method alokbarsode
2009-05-12 12:26 ` [PATCH 6/7] Adding set_limited_discoverable method to hciops plugin alokbarsode
2009-05-12 12:26 ` [PATCH 7/7] Code cleanup in set_mode alokbarsode
2009-05-15 18:22 ` Johan Hedberg [this message]
2009-05-16 22:54 ` [PATCH 2/7] Adding set_powered method to hciops plugin Johan Hedberg
2009-05-17 7:27 ` alok barsode
2009-05-17 18:42 ` Johan Hedberg
-- strict thread matches above, loose matches on Subject: below --
2009-05-18 9:49 [PATCH 1/7] Using hci_send_cmd instead of hci_send_req to set scan mode alokbarsode
2009-05-18 9:49 ` [PATCH 2/7] Adding set_powered method to hciops plugin alokbarsode
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090515182256.GA18375@jh-x301 \
--to=johan.hedberg@gmail.com \
--cc=alok.barsode@azingo.com \
--cc=alokbarsode@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox