From: Johan Hedberg <johan.hedberg@gmail.com>
To: alokbarsode@gmail.com
Cc: linux-bluetooth@vger.kernel.org, Alok Barsode <alok.barsode@azingo.com>
Subject: Re: [PATCH 1/1] Adding start_discovery functionality to hciops plugin.
Date: Fri, 29 May 2009 16:20:46 +0300 [thread overview]
Message-ID: <20090529132046.GA10997@jh-x301> (raw)
In-Reply-To: <1243601080-27314-1-git-send-email-alok.barsode@azingo.com>
Hi Alok,
One minor comment:
On Fri, May 29, 2009, alokbarsode@gmail.com wrote:
> +static int hciops_start_discovery(int index, gboolean periodic)
> +{
> + inquiry_cp inq_cp;
> + periodic_inquiry_cp cp;
Put these two variables into the if-else statement since that's the only
place where they are used. Otherwise the patch looks pretty good.
Johan
next prev parent reply other threads:[~2009-05-29 13:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-29 12:44 [PATCH 1/1] Adding start_discovery functionality to hciops plugin alokbarsode
2009-05-29 13:20 ` Johan Hedberg [this message]
2009-05-29 13:43 ` alok barsode
2009-05-29 14:06 ` alok barsode
-- strict thread matches above, loose matches on Subject: below --
2009-05-21 13:24 alokbarsode
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090529132046.GA10997@jh-x301 \
--to=johan.hedberg@gmail.com \
--cc=alok.barsode@azingo.com \
--cc=alokbarsode@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox