From: Johan Hedberg <johan.hedberg@gmail.com>
To: Forrest Zhao <forrest.zhao@intel.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] fix the bug introduced by commit "re-use the sco_server initiated by audio plugin"
Date: Fri, 19 Jun 2009 16:01:38 +0300 [thread overview]
Message-ID: <20090619130138.GA14451@jh-x301> (raw)
In-Reply-To: <1245389422-22318-1-git-send-email-forrest.zhao@intel.com>
Hi Forrest,
On Fri, Jun 19, 2009, Forrest Zhao wrote:
> @@ -1079,9 +1079,6 @@ int gateway_connect_sco(struct audio_device *dev, GIOChannel *io)
> {
> struct gateway *gw = dev->gateway;
>
> - if (gw->sco)
> - return -EISCONN;
> -
> gw->sco = g_io_channel_ref(io);
This part looks wrong. If gw->sco is non-NULL you'd be causing a memory
leak. Why do you think that returning -EISCONN is wrong here?
Johan
next prev parent reply other threads:[~2009-06-19 13:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-19 5:30 [PATCH] fix the bug introduced by commit "re-use the sco_server initiated by audio plugin" Forrest Zhao
2009-06-19 13:01 ` Johan Hedberg [this message]
2009-06-19 15:38 ` Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090619130138.GA14451@jh-x301 \
--to=johan.hedberg@gmail.com \
--cc=forrest.zhao@intel.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox