From: Johan Hedberg <johan.hedberg@gmail.com>
To: Forrest Zhao <forrest.zhao@intel.com>
Cc: linux-bluetooth@vger.kernel.org, forrest.zhao@gmail.com
Subject: Re: [PATCH] misc fixes for HFP HF role
Date: Tue, 30 Jun 2009 12:44:57 +0300 [thread overview]
Message-ID: <20090630094457.GA3877@jh-x301> (raw)
In-Reply-To: <1246353052-26175-1-git-send-email-forrest.zhao@intel.com>
Hi Forrest,
There were still a couple of issues:
On Tue, Jun 30, 2009, Forrest Zhao wrote:
> + debug("connection with remote BT is closed\n");
Redundant newline character.
> if (cond & (G_IO_ERR | G_IO_HUP)) {
> + debug("sco connection is released\n");
> GIOChannel *chan = gw->sco;
Variable declaration after code and redundant newline character.
> - g_io_channel_close(chan);
> + g_io_channel_shutdown(chan);
Too few parameters to g_io_channel_shutdown. Please at least compile-check
before submitting patches, even if your change is trivial.
However, I went ahead and fixed these issues myself and pushed the patch
upstream.
It seems that there were plenty of redundant newline characters in debug
logs in gateway.c (where you probably got the wrong idea to start with)
and I fixed these in a separate commit.
Johan
prev parent reply other threads:[~2009-06-30 9:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-30 9:10 [PATCH] misc fixes for HFP HF role Forrest Zhao
2009-06-30 9:44 ` Johan Hedberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090630094457.GA3877@jh-x301 \
--to=johan.hedberg@gmail.com \
--cc=forrest.zhao@gmail.com \
--cc=forrest.zhao@intel.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox