From: Johan Hedberg <johan.hedberg@gmail.com>
To: Filippo Giunchedi <filippo@esaurito.net>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 3/3] test/agent.c: pairing via CreatePairedDevice
Date: Tue, 30 Jun 2009 18:39:10 +0300 [thread overview]
Message-ID: <20090630153910.GA5428@jh-x301> (raw)
In-Reply-To: <1246375008-8282-3-git-send-email-filippo@esaurito.net>
Hi Filippo,
Thanks for the updated patches. There are still some issues however:
$ test/agent 1234
Can't register agent
Method "RegisterAgent" with signature "os" on interface "org.bluez.Adapter" doesn't exist
whereas running test/simple-agent (without arguments) works fine. Or am I
giving the wrong arguments to test/agent in order to run it in passive
mode?
Also, the RequestPasskey agent method is only used if we are a Bluetooth
2.1 keyboard, so it's not particularly useful for the typical environment
that BlueZ gets run in. To get at least the most common Bluetooth 2.1
Secure Simple Pairing cases covered at least the RequestConfirmation and
DisplayPasskey callbacks should be supported. Also, once these do become
supported the PIN code command line parameter should probably be set as
optional since you won't be asked for a PIN code when doing SSP.
I guess these patches do improve the current situation in anycase since
now calling CreatePairedDevice should at least be possible with test/agent
but I'm not sure if I should wait for another update or just apply the
current versions. Marcel?
Johan
next prev parent reply other threads:[~2009-06-30 15:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-28 18:27 [PATCH 1/4] test/agent.c: honour commandline --device Filippo Giunchedi
2009-06-28 18:27 ` [PATCH 2/4] test/agent.c: update dbus API usage Filippo Giunchedi
2009-06-28 18:27 ` [PATCH 3/4] test/agent.c: register object path only Filippo Giunchedi
2009-06-30 13:34 ` Johan Hedberg
2009-06-30 15:16 ` [PATCH 1/3] test/agent.c: honour commandline --device Filippo Giunchedi
2009-06-30 15:16 ` [PATCH 2/3] test/agent.c: update dbus API usage Filippo Giunchedi
2009-06-30 15:16 ` [PATCH 3/3] test/agent.c: pairing via CreatePairedDevice Filippo Giunchedi
2009-06-30 15:39 ` Johan Hedberg [this message]
2009-06-30 15:48 ` Filippo Giunchedi
2009-06-28 18:27 ` [PATCH 4/4] " Filippo Giunchedi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090630153910.GA5428@jh-x301 \
--to=johan.hedberg@gmail.com \
--cc=filippo@esaurito.net \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox