Re: [PATCH] Add introspection interface to the output of introspection calls.

[Johan Hedberg <johan.hedberg@gmail.com>]

Hi Gergely,

On Mon, Sep 14, 2009, RISKÓ Gergely wrote:
> Thank you for all of your advise, here is the result.
> 
> BR,
> Gergely
> 
> From 91b64b5cd3b174317bde5f9ccf4cc1d420086eb7 Mon Sep 17 00:00:00 2001
> From: Gergely Risko <gergely@risko.hu>
> Date: Mon, 14 Sep 2009 17:46:29 +0300
> Subject: [PATCH] Add introspection interface description into the DBus introspection replies.
> 
> ---
>  gdbus/object.c |    8 +++++++-
>  1 files changed, 7 insertions(+), 1 deletions(-)

Thanks! The patch has now been pushed upstream.

One thing that came to my mind is that it might be possible to simplify
the code by making the introspection interface less of a special case
within gdbus:

Instead of hard coding this XML snippet and handling the Introspect method
call separately from the rest of the method calls for a particular object
path gdbus could use its own public interface registration system
(i.e. g_dbus_register_interface) to implicitly register the Introspectable
interface as the first interface when creating new object paths. This way
the existing interface callback mechanism would do most of the work and
there wouldn't be a need to explicitly add the extra snippet to the XML
output like your patch now does.

Any thoughts on this?

Johan