From: Johan Hedberg <johan.hedberg@gmail.com>
To: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: "Valmantas Palikša" <walmis@gmail.com>, linux-bluetooth@vger.kernel.org
Subject: Re: Corruption in bluetoothd if started when adapter was rfkilled
Date: Tue, 20 Oct 2009 23:14:11 +0300 [thread overview]
Message-ID: <20091020201411.GA6878@jh-x301> (raw)
In-Reply-To: <2d5a2c100910201257g45d802cia7719035874c5a3d@mail.gmail.com>
Hi Luiz,
On Tue, Oct 20, 2009, Luiz Augusto von Dentz wrote:
> On Tue, Oct 20, 2009 at 10:38 AM, Johan Hedberg <johan.hedberg@gmail.com> wrote:
> > Hi,
> >
> > On Fri, Oct 16, 2009, Valmantas Palikša wrote:
> >> Steps to reproduce:
> >> 1. rfkill block bluetooth
> >> 2. start bluetoothd
> >> 3. kill bluetoothd
> >
> > I don't seem to have rfkill support (at least using that command) on my
> > laptop so I can't verify this fix, but could you try the attached patch
> > and see if it resolves the issue? The problem seems to be that in this use
> > case we never load/probe the adapter drivers but still call their remove
> > callbacks when the adapter initialization fails. This causes some drivers
> > to call btd_adapter_unref on adapter objects for which they do not own a
> > reference.
>
> Yep, it fixes the problem.
Great! The patch is now pushed upstream.
Johan
prev parent reply other threads:[~2009-10-20 20:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-16 12:41 Corruption in bluetoothd if started when adapter was rfkilled Valmantas Palikša
2009-10-20 13:38 ` Johan Hedberg
2009-10-20 19:57 ` Luiz Augusto von Dentz
2009-10-20 20:14 ` Johan Hedberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091020201411.GA6878@jh-x301 \
--to=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=walmis@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox