public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
From: Johan Hedberg <johan.hedberg@gmail.com>
To: jaikumar@google.com
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Fix SDP handling when the SDP record is modified on remote device.
Date: Fri, 23 Oct 2009 02:11:24 +0300	[thread overview]
Message-ID: <20091022231124.GA15283@jh-x301> (raw)
In-Reply-To: <1256251587-18043-1-git-send-email-jaikumar@google.com>

Hi Jaikumar,

On Thu, Oct 22, 2009, jaikumar@google.com wrote:
> We invalidate the in-memory SDP records list only when a profile
> is added or removed. So when a SDP record attribute like the rfcomm
> channel number is modified on the remote device, we will miss the update.
> ---
>  src/device.c |   10 +++++-----
>  1 files changed, 5 insertions(+), 5 deletions(-)

The patch makes sense and has been pushed upstream. Thanks. However, I'm
not aware of any code in the current bluez tree that would actually try to
use the cached RFCOMM channels. E.g. the serial plugin as well as the
HFP/HSP implementation always do explicit lookups over SDP before
attempting to connect. So most likely there's no immediate benefit of the
patch but it's still good to have it in case some future code does rely
more heavily on the SDP record cache.

Johan

      reply	other threads:[~2009-10-22 23:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-22 22:46 [PATCH] Fix SDP handling when the SDP record is modified on remote device jaikumar
2009-10-22 23:11 ` Johan Hedberg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091022231124.GA15283@jh-x301 \
    --to=johan.hedberg@gmail.com \
    --cc=jaikumar@google.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox