From: Johan Hedberg <johan.hedberg@gmail.com>
To: Bastien Nocera <hadess@hadess.net>
Cc: BlueZ development <linux-bluetooth@vger.kernel.org>
Subject: Re: Battery information
Date: Fri, 6 Nov 2009 22:54:24 +0200 [thread overview]
Message-ID: <20091106205424.GA16451@jh-x301> (raw)
In-Reply-To: <1257538523.23167.203.camel@localhost.localdomain>
On Fri, Nov 06, 2009, Bastien Nocera wrote:
> > I don't really see the point of this patch. What's the benefit of
> > returning "OK" instead of "ERROR" in this case, especially since the
> > added command handler doesn't do anything? As far as I see returning
> > "ERROR" is the right behavior for us when we encounter a command which
> > we don't understand (there are also no other side effects on our side
> > when we send an error, i.e. the connection is allowed proceed normally).
>
> Nobody likes errors showing up in their /var/log/messages. In any case,
> that was a minimal patch to avoid that.
If that's the main issue here I'd rather just change the error() into a
debug() in the code. You'll get much more than just one message like
that when connecting e.g. to a CSR based headset since they use lots of
vendor-specific AT commands.
Johan
prev parent reply other threads:[~2009-11-06 20:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-06 18:56 Battery information Bastien Nocera
2009-11-06 19:58 ` Johan Hedberg
2009-11-06 20:15 ` Bastien Nocera
2009-11-06 20:54 ` Johan Hedberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091106205424.GA16451@jh-x301 \
--to=johan.hedberg@gmail.com \
--cc=hadess@hadess.net \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox