From: Johan Hedberg <johan.hedberg@gmail.com>
To: Susanne Goldammer <susanne.goldammer@gmx.de>
Cc: Bastien Nocera <hadess@hadess.net>,
BlueZ devel list <linux-bluetooth@vger.kernel.org>
Subject: Re: Make bluetoothd start w/o SDP Server
Date: Fri, 13 Nov 2009 13:33:35 +0200 [thread overview]
Message-ID: <20091113113335.GA18325@jh-x301> (raw)
In-Reply-To: <4AFC26C3.50006@gmx.de>
Hi Susanne,
On Thu, Nov 12, 2009, Susanne Goldammer wrote:
> Fixed. New patch attached.
The patch looks good except for two more white-space issues:
> +static gboolean option_runsdp = TRUE;
> +
>
> static guint last_adapter_timeout = 0;
No need to add another extra line here (in general there shouldn't be a
need to have two consequtive empty lines almost anywhere in the source).
> + if (option_runsdp == TRUE)
It looks like this has an extra space at the end before the newline
character.
Additionally, could you please create a patch using git format-patch so
that it can be applied using git am and you get proper credit for it
(through the author field). Thanks.
Johan
next prev parent reply other threads:[~2009-11-13 11:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-10 14:00 Make bluetoothd start w/o SDP Server Susanne Goldammer
2009-11-10 14:05 ` Bastien Nocera
2009-11-10 14:19 ` Susanne Goldammer
2009-11-12 9:21 ` Susanne Goldammer
2009-11-12 10:16 ` Iain Hibbert
2009-11-12 10:47 ` Susanne Goldammer
2009-11-12 12:13 ` Stefan Seyfried
2009-11-12 12:55 ` Susanne Goldammer
2009-11-12 13:08 ` Stefan Seyfried
2009-11-12 14:13 ` Susanne Goldammer
2009-11-12 14:57 ` Bastien Nocera
2009-11-12 15:16 ` Susanne Goldammer
2009-11-13 11:33 ` Johan Hedberg [this message]
2009-11-13 11:58 ` Marcel Holtmann
2009-11-13 12:33 ` Johan Hedberg
2009-11-13 12:36 ` Susanne Goldammer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091113113335.GA18325@jh-x301 \
--to=johan.hedberg@gmail.com \
--cc=hadess@hadess.net \
--cc=linux-bluetooth@vger.kernel.org \
--cc=susanne.goldammer@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox