From: Johan Hedberg <johan.hedberg@gmail.com>
To: "Daniel Örstadius" <daniel.orstadius@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] spurious disconnection attempt
Date: Thu, 17 Dec 2009 16:07:11 +0200 [thread overview]
Message-ID: <20091217140711.GA1481@jh-x301> (raw)
In-Reply-To: <eb7933e20912170544p2d07fc0endc0c50026e42f8c1@mail.gmail.com>
Hi Daniel,
On Thu, Dec 17, 2009, Daniel Örstadius wrote:
> The problem seems to be that bluetoothd still calls
> src/device.c:do_disconnect even though the link has been disconnected.
> Attaching a patch proposal for function device_remove_connection to
> try to avoid this. The function looks to be called only when there is
> no longer an hci connection to the remote.
Thanks! The patch looks good and I've pushed it upstream. In the future,
please pay a little bit more attention to your commit messages. Usually
we start the summary lines of bugfixes with "Fix.." and feature
additions with "Add.." or "Implement.." as well as include an
appropriately detailed description of the commit for any non-trivial
change. I now fixed the commit messages of your two latest patches
manually and you can check the result in the upstream git tree.
Johan
prev parent reply other threads:[~2009-12-17 14:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-17 13:44 [PATCH] spurious disconnection attempt Daniel Örstadius
2009-12-17 14:07 ` Johan Hedberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091217140711.GA1481@jh-x301 \
--to=johan.hedberg@gmail.com \
--cc=daniel.orstadius@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).